aurora-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Stephan Erb <s...@apache.org>
Subject Re: Review Request 54957: Add option to not retry api calls to the scheduler.
Date Mon, 27 Mar 2017 22:22:10 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/54957/#review170233
-----------------------------------------------------------




src/main/python/apache/aurora/client/api/scheduler_client.py
Line 324 (original), 324 (patched)
<https://reviews.apache.org/r/54957/#comment243023>

    Could you please elaborate why TransportException and TransientError require special retry
handling, whereas a TimeoutError can always be retried? Sorry if I have missed some previous
discussion.


- Stephan Erb


On March 24, 2017, 7:30 p.m., Karthik Anantha Padmanabhan wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/54957/
> -----------------------------------------------------------
> 
> (Updated March 24, 2017, 7:30 p.m.)
> 
> 
> Review request for Aurora, David McLaughlin, Joshua Cohen, Santhosh Kumar Shanmugham,
and Zameer Manji.
> 
> 
> Repository: aurora
> 
> 
> Description
> -------
> 
> This diff adds an option to not retry api calls to the scheduler. For some of the non-idempotent
operations we would like to not automatically retry. This patch makes this functionality available
only to the `schedule_backup_now` command.
> 
> If there is consensus, this can be added to all commands as well.
> 
> 
> Diffs
> -----
> 
>   src/main/python/apache/aurora/admin/admin.py 070c348d2ca5db1edecf832efd9aa5481bddaa4b

>   src/main/python/apache/aurora/client/api/__init__.py e1dde638bd1d686269fbcd88cb083a52e7f5dbfc

>   src/main/python/apache/aurora/client/api/scheduler_client.py 9bbfece012e48e0b1752bbefd25c89e04d312cf6

>   src/test/python/apache/aurora/client/api/test_scheduler_client.py f6018caa4f431e85a9e9ff203ac3d4b6c33f40ef

> 
> 
> Diff: https://reviews.apache.org/r/54957/diff/6/
> 
> 
> Testing
> -------
> 
> * Manual testing
> * ./build-support/jenkins/build.sh passes
> 
> 
> Thanks,
> 
> Karthik Anantha Padmanabhan
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message