aurora-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Karthik Anantha Padmanabhan <treadston...@gmail.com>
Subject Re: Review Request 54957: Add option to not retry api calls to the scheduler.
Date Fri, 24 Mar 2017 18:30:09 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/54957/
-----------------------------------------------------------

(Updated March 24, 2017, 6:30 p.m.)


Review request for Aurora, David McLaughlin, Joshua Cohen, Santhosh Kumar Shanmugham, and
Zameer Manji.


Repository: aurora


Description
-------

This diff adds an option to not retry api calls to the scheduler. For some of the non-idempotent
operations we would like to not automatically retry. This patch makes this functionality available
only to the `schedule_backup_now` command.

If there is consensus, this can be added to all commands as well.


Diffs (updated)
-----

  src/main/python/apache/aurora/admin/admin.py 070c348d2ca5db1edecf832efd9aa5481bddaa4b 
  src/main/python/apache/aurora/client/api/__init__.py e1dde638bd1d686269fbcd88cb083a52e7f5dbfc

  src/main/python/apache/aurora/client/api/scheduler_client.py 9bbfece012e48e0b1752bbefd25c89e04d312cf6

  src/test/python/apache/aurora/client/api/test_scheduler_client.py f6018caa4f431e85a9e9ff203ac3d4b6c33f40ef



Diff: https://reviews.apache.org/r/54957/diff/6/

Changes: https://reviews.apache.org/r/54957/diff/5-6/


Testing
-------

* Manual testing
* ./build-support/jenkins/build.sh passes


Thanks,

Karthik Anantha Padmanabhan


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message