aurora-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Aurora ReviewBot <wfar...@apache.org>
Subject Re: Review Request 57757: Make Thermos resource collection intervals configurable
Date Sun, 19 Mar 2017 16:26:21 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/57757/#review169376
-----------------------------------------------------------



Master (b8f72d1) is red with this patch.
  ./build-support/jenkins/build.sh

virtualenv-15.0.2/virtualenv_embedded/activate.ps1
virtualenv-15.0.2/virtualenv_embedded/activate.sh
virtualenv-15.0.2/virtualenv_embedded/activate_this.py
virtualenv-15.0.2/virtualenv_embedded/deactivate.bat
virtualenv-15.0.2/virtualenv_embedded/distutils-init.py
virtualenv-15.0.2/virtualenv_embedded/distutils.cfg
virtualenv-15.0.2/virtualenv_embedded/python-config
virtualenv-15.0.2/virtualenv_embedded/site.py
virtualenv-15.0.2/virtualenv_support/
virtualenv-15.0.2/virtualenv_support/__init__.py
virtualenv-15.0.2/virtualenv_support/argparse-1.4.0-py2.py3-none-any.whl
virtualenv-15.0.2/virtualenv_support/pip-8.1.2-py2.py3-none-any.whl
virtualenv-15.0.2/virtualenv_support/setuptools-21.2.1-py2.py3-none-any.whl
virtualenv-15.0.2/virtualenv_support/wheel-0.29.0-py2.py3-none-any.whl
+ touch virtualenv-15.0.2/BOOTSTRAPPED
+ popd
/home/jenkins/jenkins-slave/workspace/AuroraBot
+ exec /usr/bin/python2.7 /home/jenkins/jenkins-slave/workspace/AuroraBot/build-support/virtualenv-15.0.2/virtualenv.py
--no-download /home/jenkins/jenkins-slave/workspace/AuroraBot/build-support/python/isort.venv
New python executable in /home/jenkins/jenkins-slave/workspace/AuroraBot/build-support/python/isort.venv/bin/python2.7
Also creating executable in /home/jenkins/jenkins-slave/workspace/AuroraBot/build-support/python/isort.venv/bin/python
Installing setuptools, pip, wheel...done.
Collecting isort==4.0.0
  Downloading isort-4.0.0-py2.py3-none-any.whl
Installing collected packages: isort
Successfully installed isort-4.0.0
You are using pip version 8.1.2, however version 9.0.1 is available.
You should consider upgrading via the 'pip install --upgrade pip' command.
ERROR: /home/jenkins/jenkins-slave/workspace/AuroraBot/src/main/python/apache/thermos/observer/task_observer.py
Imports are incorrectly sorted.
--- /home/jenkins/jenkins-slave/workspace/AuroraBot/src/main/python/apache/thermos/observer/task_observer.py:before
2017-03-19 16:21:04.909082
+++ /home/jenkins/jenkins-slave/workspace/AuroraBot/src/main/python/apache/thermos/observer/task_observer.py:after
2017-03-19 16:26:20.269092
@@ -20,8 +20,8 @@
 
 """
 import os
+import threading
 import time
-import threading
 from operator import attrgetter
 
 from twitter.common import log


I will refresh this build result if you post a review containing "@ReviewBot retry"

- Aurora ReviewBot


On March 19, 2017, 4:18 p.m., Stephan Erb wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/57757/
> -----------------------------------------------------------
> 
> (Updated March 19, 2017, 4:18 p.m.)
> 
> 
> Review request for Aurora, Santhosh Kumar Shanmugham and Zameer Manji.
> 
> 
> Bugs: AURORA-1907
>     https://issues.apache.org/jira/browse/AURORA-1907
> 
> 
> Repository: aurora
> 
> 
> Description
> -------
> 
> We have noticed that on hosts with lots of active tasks (~100) the Thermos UI
> is not usable. Thermos fully utilizes one core but does not render any requests.
> 
> Dumping `/threads` indicates the observer might be backlogged by the hundred
> concurrent `TaskResourceMonitor` threads. Due to the Python GIL only one can
> make progress at a time though.
> 
> This patch is now adding options to control the resource collection interval,
> giving operators a possibility to reduce the CPU pressure.
> 
> -- 
> 
> Reviewer notes: I dropped the entrypoint test as it was heavily relying on mocks
> without significant code coverage.
> 
> 
> Diffs
> -----
> 
>   RELEASE-NOTES.md d58d2bd2558c2060aa659402ea88271bd8704cde 
>   docs/README.md 1d679e27cf26122c34a9157194f189ce3035b176 
>   docs/reference/observer-configuration.md PRE-CREATION 
>   src/main/python/apache/aurora/tools/thermos_observer.py 4bba01930434f33150b0413d20d9657b61b364c5

>   src/main/python/apache/thermos/monitoring/resource.py 53d0ff1a71c27f053c59acca556c35d1e5ac91f0

>   src/main/python/apache/thermos/observer/detector.py 79bc6329caf73fbfbb4ebf4bbad96bb1c50be1f9

>   src/main/python/apache/thermos/observer/task_observer.py 1485de8faef52716f11b82a3556064de26c67427

>   src/test/python/apache/aurora/tools/test_thermos_observer_entry_point.py e1c8dec5f26be1aec931b1a614ecc138ae63d9de

> 
> 
> Diff: https://reviews.apache.org/r/57757/diff/1/
> 
> 
> Testing
> -------
> 
> ./pants test.pytest src/{test,main}/python:: -- -v
> 
> 
> Thanks,
> 
> Stephan Erb
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message