aurora-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Stephan Erb <>
Subject Review Request 57757: Make Thermos resource collection intervals configurable
Date Sun, 19 Mar 2017 16:18:52 GMT

This is an automatically generated e-mail. To reply, visit:

Review request for Aurora, Santhosh Kumar Shanmugham and Zameer Manji.

Bugs: AURORA-1907

Repository: aurora


We have noticed that on hosts with lots of active tasks (~100) the Thermos UI
is not usable. Thermos fully utilizes one core but does not render any requests.

Dumping `/threads` indicates the observer might be backlogged by the hundred
concurrent `TaskResourceMonitor` threads. Due to the Python GIL only one can
make progress at a time though.

This patch is now adding options to control the resource collection interval,
giving operators a possibility to reduce the CPU pressure.


Reviewer notes: I dropped the entrypoint test as it was heavily relying on mocks
without significant code coverage.

----- d58d2bd2558c2060aa659402ea88271bd8704cde 
  docs/ 1d679e27cf26122c34a9157194f189ce3035b176 
  docs/reference/ PRE-CREATION 
  src/main/python/apache/aurora/tools/ 4bba01930434f33150b0413d20d9657b61b364c5

  src/main/python/apache/thermos/monitoring/ 53d0ff1a71c27f053c59acca556c35d1e5ac91f0

  src/main/python/apache/thermos/observer/ 79bc6329caf73fbfbb4ebf4bbad96bb1c50be1f9

  src/main/python/apache/thermos/observer/ 1485de8faef52716f11b82a3556064de26c67427

  src/test/python/apache/aurora/tools/ e1c8dec5f26be1aec931b1a614ecc138ae63d9de



./pants test.pytest src/{test,main}/python:: -- -v


Stephan Erb

  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message