aurora-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Aurora ReviewBot <wfar...@apache.org>
Subject Re: Review Request 57732: Use Process.oneshot() in latest psutils for faster stats retrieval.
Date Sat, 18 Mar 2017 11:26:10 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/57732/#review169363
-----------------------------------------------------------



Master (5bffe8f) is green with this patch.
  ./build-support/jenkins/build.sh

However, it appears that it might lack test coverage.

I will refresh this build result if you post a review containing "@ReviewBot retry"

- Aurora ReviewBot


On March 17, 2017, 4:38 p.m., Stephan Erb wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/57732/
> -----------------------------------------------------------
> 
> (Updated March 17, 2017, 4:38 p.m.)
> 
> 
> Review request for Aurora, Santhosh Kumar Shanmugham and Zameer Manji.
> 
> 
> Bugs: AURORA-1907
>     https://issues.apache.org/jira/browse/AURORA-1907
> 
> 
> Repository: aurora
> 
> 
> Description
> -------
> 
> Without the Process.oneshot() decorator stats retrieval can lead to
> multiple reads of the same `/proc` filesystem values. The oneshot
> decorator enables caching to speed this up. It has been added in
> psutils 5.0.
> 
> Oneshot docs: https://pythonhosted.org/psutil/#psutil.Process.oneshot
> Changelog: https://github.com/giampaolo/psutil/blob/master/HISTORY.rst#520
> 
> 
> Diffs
> -----
> 
>   3rdparty/python/requirements.txt df2db7ac1a1d62465731c057eeeef67000cb589a 
>   src/main/python/apache/thermos/monitoring/process_collector_psutil.py 3000e95e2930a01f57ac855960b5db7aabbfc0ca

> 
> 
> Diff: https://reviews.apache.org/r/57732/diff/1/
> 
> 
> Testing
> -------
> 
> ./pants test.pytest src/{test,main}/python:: --
> 
> 
> Thanks,
> 
> Stephan Erb
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message