aurora-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Mehrdad Nurolahzade <mehr...@apache.org>
Subject Re: Review Request 57708: Populate `host` and `webURL`fields of FrameworkInfo.
Date Sat, 18 Mar 2017 00:05:22 GMT


> On March 17, 2017, 5:01 p.m., Mehrdad Nurolahzade wrote:
> > src/main/java/org/apache/aurora/scheduler/app/SchedulerMain.java
> > Line 85 (original), 87 (patched)
> > <https://reviews.apache.org/r/57708/diff/2/?file=1667458#file1667458line87>
> >
> >     Needs to be mentioned in release notes.

Scratch the above comment.
This was not added with this patch.


- Mehrdad


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/57708/#review169346
-----------------------------------------------------------


On March 17, 2017, 4:36 p.m., Zameer Manji wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/57708/
> -----------------------------------------------------------
> 
> (Updated March 17, 2017, 4:36 p.m.)
> 
> 
> Review request for Aurora, Mehrdad Nurolahzade and Stephan Erb.
> 
> 
> Bugs: AURORA-1905
>     https://issues.apache.org/jira/browse/AURORA-1905
> 
> 
> Repository: aurora
> 
> 
> Description
> -------
> 
> This patch extracts out `FrameworkInfo` construction from the `DriverSettings` data class
to a factory class. This factory class combines the base info constructed via CLI arguments
with the HTTP server's host and port information. This allows us to populate the `host` and
`weburl` fields of framework info, which enhance the Mesos UI.
> 
> This is necessary for users of the `V1_DRIVER` as the new driver does not automatically
populate the `host` field. Further, by using our own host and port information, we ensure
the information in ZooKeeper, the information used for HTTP redirects and the information
in the Mesos UI are all in sync.
> 
> Note that in vagrant, the hostname and URL are `aurora.local` because we set the `--hostname`
argument of the scheduler. By default Java will set it to the FQDN or IP address of the host.
> 
> 
> Diffs
> -----
> 
>   src/jmh/java/org/apache/aurora/benchmark/StatusUpdateBenchmark.java 95496c1520413269ecb6237427720cc78f176a2d

>   src/main/java/org/apache/aurora/scheduler/app/SchedulerMain.java 3665c4d45f1dd29b4f5c8d3bcaed4b0bf3225f69

>   src/main/java/org/apache/aurora/scheduler/mesos/CommandLineDriverSettingsModule.java
ad6110a7d42ef37023a362e6da4ce35977a5ff69 
>   src/main/java/org/apache/aurora/scheduler/mesos/DriverSettings.java f477404268f96e60dba21d58e90127dcaa0122aa

>   src/main/java/org/apache/aurora/scheduler/mesos/FrameworkInfoFactory.java PRE-CREATION

>   src/main/java/org/apache/aurora/scheduler/mesos/SchedulerDriverService.java f65a29d7ad8bc49784e324e674f30a6728a9d4ae

>   src/main/java/org/apache/aurora/scheduler/mesos/VersionedMesosSchedulerImpl.java 84e3f47636d95521600e9a4c4d5b8bc8bbbff8cf

>   src/main/java/org/apache/aurora/scheduler/mesos/VersionedSchedulerDriverService.java
d928d02cab087991a8cd8896d4366f6e5dca0913 
>   src/test/java/org/apache/aurora/scheduler/app/SchedulerIT.java f5799751489a2773d116375ee17ca9e24fc3b134

>   src/test/java/org/apache/aurora/scheduler/app/local/LocalSchedulerMain.java 7151b81ce23973437aca96d92be7e99948172fb6

>   src/test/java/org/apache/aurora/scheduler/mesos/FrameworkInfoFactoryImplTest.java PRE-CREATION

>   src/test/java/org/apache/aurora/scheduler/mesos/SchedulerDriverServiceTest.java 38e913570dce06359ab2fcc56778073c3ba17277

>   src/test/java/org/apache/aurora/scheduler/mesos/VersionedMesosSchedulerImplTest.java
988ec501e62c0cf65114f4ee4d10cbc0bc85c2d7 
>   src/test/java/org/apache/aurora/scheduler/mesos/VersionedSchedulerDriverServiceTest.java
72aede85829f087bc88760e8b564d25aceb8aed8 
>   src/test/java/org/apache/aurora/scheduler/thrift/ThriftIT.java 14218213bc92fe8c6f981003996c70ebb9370902

> 
> 
> Diff: https://reviews.apache.org/r/57708/diff/3/
> 
> 
> Testing
> -------
> 
> e2e tests.
> 
> 
> File Attachments
> ----------------
> 
> Screenshot
>   https://reviews.apache.org/media/uploaded/files/2017/03/16/1e989156-ea88-4e63-be72-bcca1e45b24e__Screen_Shot_2017-03-16_at_3.41.04_PM.png
> 
> 
> Thanks,
> 
> Zameer Manji
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message