aurora-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Aurora ReviewBot <wfar...@apache.org>
Subject Re: Review Request 57732: Use Process.oneshot() in latest psutils for faster stats retrieval.
Date Fri, 17 Mar 2017 16:48:25 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/57732/#review169295
-----------------------------------------------------------



Master (e1504a7) is red with this patch.
  ./build-support/jenkins/build.sh

  Test coverage missing for org/apache/aurora/scheduler/storage/log/SnapshotStoreImpl$7
  Test coverage missing for org/apache/aurora/scheduler/storage/log/SnapshotStoreImpl$9
  Test coverage missing for org/apache/aurora/scheduler/storage/log/SnapshotStoreImpl$4
  Test coverage missing for org/apache/aurora/scheduler/storage/log/SnapshotStoreImpl$3
  Test coverage missing for org/apache/aurora/scheduler/storage/log/SnapshotStoreImpl$6
  Test coverage missing for org/apache/aurora/scheduler/storage/log/SnapshotStoreImpl$5
  Test coverage missing for org/apache/aurora/scheduler/storage/log/SnapshotStoreImpl$2
  Test coverage missing for org/apache/aurora/scheduler/storage/log/SnapshotStoreImpl$1
  Test coverage missing for org/apache/aurora/scheduler/storage/log/LogStorage$Settings
  Test coverage missing for org/apache/aurora/scheduler/storage/log/LogStorage$ScheduledExecutorSchedulingService
  Test coverage missing for org/apache/aurora/scheduler/storage/log/LogStorageModule
  Test coverage missing for org/apache/aurora/scheduler/storage/log/SnapshotStoreImpl$SnapshotField
  Test coverage missing for org/apache/aurora/scheduler/storage/backup/TemporaryStorage$TemporaryStorageFactory$1
  Test coverage missing for org/apache/aurora/scheduler/storage/backup/BackupModule
  Test coverage missing for org/apache/aurora/scheduler/storage/backup/Recovery$RecoveryImpl
  Test coverage missing for org/apache/aurora/scheduler/storage/backup/TemporaryStorage$TemporaryStorageFactory
  Test coverage missing for org/apache/aurora/scheduler/storage/backup/Recovery$RecoveryImpl$PendingRecovery
  Test coverage missing for org/apache/aurora/scheduler/TaskVars
  Test coverage missing for org/apache/aurora/scheduler/SchedulerLifecycle$DefaultDelayedActions
  Test coverage missing for org/apache/aurora/scheduler/TierManager$TierManagerImpl$TierConfig
  Test coverage missing for org/apache/aurora/scheduler/TaskVars$Counter
  Test coverage missing for org/apache/aurora/scheduler/TaskVars$1
  Test coverage missing for org/apache/aurora/scheduler/SchedulerModule$TaskEventBatchWorker
  Test coverage missing for org/apache/aurora/scheduler/HostOffer$1
  Test coverage missing for org/apache/aurora/scheduler/SchedulerModule
  Test coverage missing for org/apache/aurora/scheduler/TaskIdGenerator$TaskIdGeneratorImpl
  Test coverage missing for org/apache/aurora/scheduler/SchedulerModule$1
  Test coverage missing for org/apache/aurora/scheduler/TaskStatusHandlerImpl
  Test coverage missing for org/apache/aurora/scheduler/TaskStatusHandlerImpl$1
  Test coverage missing for org/apache/aurora/scheduler/TierModule
  Test coverage missing for org/apache/aurora/scheduler/storage/db/typehandlers/VolumeModeTypeHandler
  Test coverage missing for org/apache/aurora/scheduler/storage/db/typehandlers/CronCollisionPolicyTypeHandler

* Try:
Run with --stacktrace option to get the stack trace. Run with --info or --debug option to
get more log output.
==============================================================================

BUILD FAILED

Total time: 7 mins 15.748 secs


I will refresh this build result if you post a review containing "@ReviewBot retry"

- Aurora ReviewBot


On March 17, 2017, 9:38 a.m., Stephan Erb wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/57732/
> -----------------------------------------------------------
> 
> (Updated March 17, 2017, 9:38 a.m.)
> 
> 
> Review request for Aurora, Santhosh Kumar Shanmugham and Zameer Manji.
> 
> 
> Bugs: AURORA-1907
>     https://issues.apache.org/jira/browse/AURORA-1907
> 
> 
> Repository: aurora
> 
> 
> Description
> -------
> 
> Without the Process.oneshot() decorator stats retrieval can lead to
> multiple reads of the same `/proc` filesystem values. The oneshot
> decorator enables caching to speed this up. It has been added in
> psutils 5.0.
> 
> Oneshot docs: https://pythonhosted.org/psutil/#psutil.Process.oneshot
> Changelog: https://github.com/giampaolo/psutil/blob/master/HISTORY.rst#520
> 
> 
> Diffs
> -----
> 
>   3rdparty/python/requirements.txt df2db7ac1a1d62465731c057eeeef67000cb589a 
>   src/main/python/apache/thermos/monitoring/process_collector_psutil.py 3000e95e2930a01f57ac855960b5db7aabbfc0ca

> 
> 
> Diff: https://reviews.apache.org/r/57732/diff/1/
> 
> 
> Testing
> -------
> 
> ./pants test.pytest src/{test,main}/python:: --
> 
> 
> Thanks,
> 
> Stephan Erb
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message