aurora-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Stephan Erb <s...@apache.org>
Subject Review Request 57732: Use Process.oneshot() in latest psutils for faster stats retrieval.
Date Fri, 17 Mar 2017 16:38:04 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/57732/
-----------------------------------------------------------

Review request for Aurora, Santhosh Kumar Shanmugham and Zameer Manji.


Bugs: AURORA-1907
    https://issues.apache.org/jira/browse/AURORA-1907


Repository: aurora


Description
-------

Without the Process.oneshot() decorator stats retrieval can lead to
multiple reads of the same `/proc` filesystem values. The oneshot
decorator enables caching to speed this up. It has been added in
psutils 5.0.

Oneshot docs: https://pythonhosted.org/psutil/#psutil.Process.oneshot
Changelog: https://github.com/giampaolo/psutil/blob/master/HISTORY.rst#520


Diffs
-----

  3rdparty/python/requirements.txt df2db7ac1a1d62465731c057eeeef67000cb589a 
  src/main/python/apache/thermos/monitoring/process_collector_psutil.py 3000e95e2930a01f57ac855960b5db7aabbfc0ca



Diff: https://reviews.apache.org/r/57732/diff/1/


Testing
-------

./pants test.pytest src/{test,main}/python:: --


Thanks,

Stephan Erb


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message