aurora-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Zameer Manji <zma...@apache.org>
Subject Re: Review Request 57524: Support setting the rootfs on Mesos Containers.
Date Tue, 14 Mar 2017 03:09:14 GMT


> On March 11, 2017, 4:28 a.m., Stephan Erb wrote:
> > I need a little bit more context to understand what is going on here:
> > 
> > * Do you plan to use this with Thermos or an alternative executor? Or both?
> > * It seems like we don't need this for Thermos as we already create mountpoints
when needed (see do_mount() in aurora/executor/common/sandbox.py)
> > * Switching the flag will run the executor within the filesystem image and thus
require Python and all libmesos dependencies within the image. This sounds like a big downfall
just for gaining the mkdir.
> 
> Joshua Cohen wrote:
>     +1, it's unclear to me why this is necessary. If it is, I'd consider it a bug in
the sandbox code that prepares mounts. It should be making any directories that don't already
exist under taskfs:
>     
>     
>         # If we're mounting a file into the task filesystem, the mount call will fail
if the mount
>         # point doesn't exist. In that case we'll create an empty file to mount over.
>         if os.path.isfile(source) and not os.path.exists(destination):
>           safe_mkdir(os.path.dirname(destination))
>           touch(destination)
>         else:
>           safe_mkdir(destination)
>     
>     https://github.com/apache/aurora/blob/master/src/main/python/apache/aurora/executor/common/sandbox.py#L284-L290

I see that I have been unclear here. I will take some time to better document the problem
to explain why I think this is necesssary.


- Zameer


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/57524/#review168709
-----------------------------------------------------------


On March 13, 2017, 9:36 a.m., Zameer Manji wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/57524/
> -----------------------------------------------------------
> 
> (Updated March 13, 2017, 9:36 a.m.)
> 
> 
> Review request for Aurora, Santhosh Kumar Shanmugham and Stephan Erb.
> 
> 
> Bugs: AURORA-1903
>     https://issues.apache.org/jira/browse/AURORA-1903
> 
> 
> Repository: aurora
> 
> 
> Description
> -------
> 
> The mesos unified containerizer does not support absolute container path mounts if no
rootfs is set. This allows operators to switch between our current behaviour (mounting images
as a volume) and setting the rootfs. See AURORA-1903 for more detailed analysis.
> 
> 
> Diffs
> -----
> 
>   src/main/java/org/apache/aurora/scheduler/base/TaskTestUtil.java f0b148cd158d61cd89cc51dca9f3fa4c6feb1b49

>   src/main/java/org/apache/aurora/scheduler/configuration/executor/ExecutorModule.java
4dac9757a65e144142d36ee921b85a02a5311fe5 
>   src/main/java/org/apache/aurora/scheduler/configuration/executor/ExecutorSettings.java
5c987fd051728486172c8afd34219e86d56f00d5 
>   src/main/java/org/apache/aurora/scheduler/mesos/MesosTaskFactory.java 0d639f66db456858278b0485c91c40975c3b45ac

>   src/main/java/org/apache/aurora/scheduler/mesos/TestExecutorSettings.java e1cd81e6fbd98f23046e6e775be268be4310c62a

>   src/test/java/org/apache/aurora/scheduler/mesos/MesosTaskFactoryImplTest.java 93cc34cf8393f969087cd0fd6f577228c00170e9

> 
> 
> Diff: https://reviews.apache.org/r/57524/diff/1/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Zameer Manji
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message