aurora-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Santhosh Kumar Shanmugham <santhoshkuma...@gmail.com>
Subject Re: Review Request 55951: Use --launch_info when invoking MesosContainerizer.
Date Tue, 14 Mar 2017 01:57:02 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/55951/
-----------------------------------------------------------

(Updated March 13, 2017, 6:57 p.m.)


Review request for Aurora, Joshua Cohen, Stephan Erb, and Karthik Anantha Padmanabhan.


Changes
-------

Use sh supported `if` in the shell script. Bash syntax is not working.


Bugs: AURORA-1882
    https://issues.apache.org/jira/browse/AURORA-1882


Repository: aurora


Description
-------

MesosContainerizer has updated the command line parameters in 1.2.0 and
consolidated the individual arguments into a single ContainerLaunchInfo
proto buf message. Update ThermosExecutor to use the new `--launch_info`
parameter to be compatible with MesosContainerizer also check the
containerizer binary interface to determine to be backward-compatible.


Diffs (updated)
-----

  RELEASE-NOTES.md 1142f75bbdd488a3e4966f187c0c55879241989b 
  src/main/python/apache/thermos/common/process_util.py 54e716b726fc02f3901f1b9143d3fa253511e29b

  src/test/python/apache/aurora/executor/common/test_health_checker.py a3b5a22a805753d42e97f8f1e4e3dab7d3c9c507

  src/test/python/apache/thermos/core/test_process.py 520390217f691b9136cb4d36262be3d372a16509



Diff: https://reviews.apache.org/r/55951/diff/3/

Changes: https://reviews.apache.org/r/55951/diff/2-3/


Testing
-------

build-support/jenkins/build.sh
src/test/sh/org/apache/aurora/e2e/test_end_to_end.sh


Thanks,

Santhosh Kumar Shanmugham


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message