aurora-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Stephan Erb <s...@apache.org>
Subject Re: Review Request 57524: Support setting the rootfs on Mesos Containers.
Date Sat, 11 Mar 2017 12:28:31 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/57524/#review168709
-----------------------------------------------------------



I need a little bit more context to understand what is going on here:

* Do you plan to use this with Thermos or an alternative executor? Or both?
* It seems like we don't need this for Thermos as we already create mountpoints when needed
(see do_mount() in aurora/executor/common/sandbox.py)
* Switching the flag will run the executor within the filesystem image and thus require Python
and all libmesos dependencies within the image. This sounds like a big downfall just for gaining
the mkdir.


src/main/java/org/apache/aurora/scheduler/configuration/executor/ExecutorModule.java
Lines 108-111 (patched)
<https://reviews.apache.org/r/57524/#comment240989>

    If the need for the flag is executor specific, it will make sense to move this to the
executor config rather than maintain it as a global toggle.
    
    We should probably:
    
    * add this to the changelog
    * mention and explain this in either https://github.com/apache/aurora/blob/master/docs/features/containers.md#mesos-containerizer
or https://github.com/apache/aurora/blob/master/docs/features/custom-executors.md


- Stephan Erb


On March 11, 2017, 1:27 a.m., Zameer Manji wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/57524/
> -----------------------------------------------------------
> 
> (Updated March 11, 2017, 1:27 a.m.)
> 
> 
> Review request for Aurora, Santhosh Kumar and Stephan Erb.
> 
> 
> Bugs: AURORA-1903
>     https://issues.apache.org/jira/browse/AURORA-1903
> 
> 
> Repository: aurora
> 
> 
> Description
> -------
> 
> The mesos unified containerizer does not support absolute container path mounts if no
rootfs is set. This allows operators to switch between our current behaviour (mounting images
as a volume) and setting the rootfs. See AURORA-1903 for more detailed analysis.
> 
> 
> Diffs
> -----
> 
>   src/main/java/org/apache/aurora/scheduler/base/TaskTestUtil.java f0b148cd158d61cd89cc51dca9f3fa4c6feb1b49

>   src/main/java/org/apache/aurora/scheduler/configuration/executor/ExecutorModule.java
4dac9757a65e144142d36ee921b85a02a5311fe5 
>   src/main/java/org/apache/aurora/scheduler/configuration/executor/ExecutorSettings.java
5c987fd051728486172c8afd34219e86d56f00d5 
>   src/main/java/org/apache/aurora/scheduler/mesos/MesosTaskFactory.java 0d639f66db456858278b0485c91c40975c3b45ac

>   src/main/java/org/apache/aurora/scheduler/mesos/TestExecutorSettings.java e1cd81e6fbd98f23046e6e775be268be4310c62a

>   src/test/java/org/apache/aurora/scheduler/mesos/MesosTaskFactoryImplTest.java 93cc34cf8393f969087cd0fd6f577228c00170e9

> 
> 
> Diff: https://reviews.apache.org/r/57524/diff/1/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Zameer Manji
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message