aurora-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Zameer Manji <zma...@apache.org>
Subject Re: Review Request 57061: Enable Mesos HTTP API.
Date Thu, 02 Mar 2017 21:28:57 GMT


> On March 2, 2017, 12:36 p.m., Mehrdad Nurolahzade wrote:
> > src/main/java/org/apache/aurora/scheduler/app/SchedulerMain.java
> > Lines 112 (patched)
> > <https://reviews.apache.org/r/57061/diff/12/?file=1652865#file1652865line112>
> >
> >     We are defaulting to `SCHEDULER_DRIVER` here and `V1_DRIVER` under vagrant,
which is fine. 
> >     
> >     However, reading the release notes, I somehow got the impression that we have
defaulted to `V1_DRIVER` going forward. Consider clarifying this in the relase notes.

I just removed the `V1_DRIVER` line at the end for now.


> On March 2, 2017, 12:36 p.m., Mehrdad Nurolahzade wrote:
> > src/main/java/org/apache/aurora/scheduler/mesos/LibMesosLoadingModule.java
> > Lines 49 (patched)
> > <https://reviews.apache.org/r/57061/diff/12/?file=1652866#file1652866line49>
> >
> >     Consider adding an error message to `checkState()`.

Done.


> On March 2, 2017, 12:36 p.m., Mehrdad Nurolahzade wrote:
> > src/main/java/org/apache/aurora/scheduler/mesos/MesosCallbackHandler.java
> > Lines 211 (patched)
> > <https://reviews.apache.org/r/57061/diff/12/?file=1652867#file1652867line211>
> >
> >     This looks kind of weird now (seems like you dropped unused parameteres).

Yes, this is weird. I have enhanced it to log some information about the message but not the
body itself.


> On March 2, 2017, 12:36 p.m., Mehrdad Nurolahzade wrote:
> > src/main/java/org/apache/aurora/scheduler/mesos/SchedulerDriverModule.java
> > Lines 70 (patched)
> > <https://reviews.apache.org/r/57061/diff/12/?file=1652870#file1652870line78>
> >
> >     Consider augmenting `checkState()` with an error message.

Done.


- Zameer


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/57061/#review167579
-----------------------------------------------------------


On March 1, 2017, 11:14 a.m., Zameer Manji wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/57061/
> -----------------------------------------------------------
> 
> (Updated March 1, 2017, 11:14 a.m.)
> 
> 
> Review request for Aurora, David McLaughlin, Mehrdad Nurolahzade, and Stephan Erb.
> 
> 
> Bugs: AURORA-1887 and AURORA-1888
>     https://issues.apache.org/jira/browse/AURORA-1887
>     https://issues.apache.org/jira/browse/AURORA-1888
> 
> 
> Repository: aurora
> 
> 
> Description
> -------
> 
> This patch completes the design doc[1] and enables operators to choose between
> two V1 Mesos API implementations. The first is `V0Mesos` which offers the V1 API
> backed by the scheduler driver and the second is `V1Mesos` which offers the V1
> API backed by a new HTTP API implementation.
> 
> There are three sets of changes in this patch.
> 
> First, the V1 Mesos code requires a Scheduler callback with a different API. To
> maximize code reuse, event handling logic was extracted into a `MesosCallbackHandler`
> class. `VersionedMesosSchedulerImpl` was created to implement the new
> callback interface. Both callbacks new use the handler class for logic.
> 
> Second, a new driver implementation using the new API was created. All of the
> logic for the new driver is encapsulated in the
> `VersionedSchedulerDriverService` class.
> 
> Third, some wiring changes were done to allow for Guice to do it's work and
> allow for operators to select between the different driver implementations.
> 
> [1] https://docs.google.com/document/d/1bWK8ldaQSsRXvdKwTh8tyR_0qMxAlnMW70eOKoU3myo
> 
> 
> Diffs
> -----
> 
>   RELEASE-NOTES.md 2391d32b47dfbb2884bcefac803ec77ee82b4b27 
>   examples/vagrant/upstart/aurora-scheduler.conf 49fdcbd8b7406a59ae7882473b9eddbfce3ece7c

>   src/jmh/java/org/apache/aurora/benchmark/StatusUpdateBenchmark.java 6c2bf46c0d55ac6a85fed7244cba24d74e1b34aa

>   src/main/java/org/apache/aurora/scheduler/app/AppModule.java e2ef9c30720698263106f22e3e24db5d0468b155

>   src/main/java/org/apache/aurora/scheduler/app/SchedulerMain.java 805e9de9bc45396cb8fc6e33ddb3d7428312c608

>   src/main/java/org/apache/aurora/scheduler/mesos/LibMesosLoadingModule.java e1a23590c795a489e753b77b0835d30d3be174b5

>   src/main/java/org/apache/aurora/scheduler/mesos/MesosCallbackHandler.java PRE-CREATION

>   src/main/java/org/apache/aurora/scheduler/mesos/MesosSchedulerImpl.java eb210962c54cd0d33e3760b32f5b0ca1a7079204

>   src/main/java/org/apache/aurora/scheduler/mesos/ProtosConversion.java bc9e23b7410c00b7d5ffa4f23db93a51e9d0f405

>   src/main/java/org/apache/aurora/scheduler/mesos/SchedulerDriverModule.java 5519323079b2c957a23e093dcc77929148b4a59a

>   src/main/java/org/apache/aurora/scheduler/mesos/VersionedDriverFactory.java PRE-CREATION

>   src/main/java/org/apache/aurora/scheduler/mesos/VersionedMesosSchedulerImpl.java PRE-CREATION

>   src/main/java/org/apache/aurora/scheduler/mesos/VersionedSchedulerDriverService.java
PRE-CREATION 
>   src/test/java/org/apache/aurora/scheduler/app/SchedulerIT.java 05518048ca5518a007281269aa402a7d0710eb62

>   src/test/java/org/apache/aurora/scheduler/mesos/MesosCallbackHandlerTest.java PRE-CREATION

>   src/test/java/org/apache/aurora/scheduler/mesos/MesosSchedulerImplTest.java c599fe30bc903b3a3fb178df70a46d2421b6c45e

>   src/test/java/org/apache/aurora/scheduler/mesos/VersionedMesosSchedulerImplTest.java
PRE-CREATION 
>   src/test/java/org/apache/aurora/scheduler/mesos/VersionedSchedulerDriverServiceTest.java
PRE-CREATION 
>   src/test/java/org/apache/aurora/scheduler/thrift/ThriftIT.java f2275c757ebfa52179e31b95bf0c02b6753fb7e3

> 
> 
> Diff: https://reviews.apache.org/r/57061/diff/12/
> 
> 
> Testing
> -------
> 
> The e2e test has been run three times, each time with a different driver option.
> 
> 
> Thanks,
> 
> Zameer Manji
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message