Mailing-List: contact reviews-help@aurora.apache.org; run by ezmlm
Precedence: bulk
Reply-To: reviews@aurora.apache.org
Content-Type: multipart/alternative;
 boundary="===============1117553890645689364=="
MIME-Version: 1.0
Subject: Re: Review Request 56723: Add best effort pulse timestamp recovery.
From: Aurora ReviewBot <wfarner@apache.org>
To: Santhosh Kumar Shanmugham <santhoshkumar.s@gmail.com>,
 David McLaughlin <david@dmclaughlin.com>
Cc: Aurora ReviewBot <wfarner@apache.org>, Zameer Manji <zmanji@apache.org>,
 Aurora <reviews@aurora.apache.org>
Date: Wed, 15 Feb 2017 23:37:22 -0000
Message-ID: <20170215233722.13056.73191@reviews.apache.org>
Auto-Submitted: auto-generated
Sender: Aurora ReviewBot <noreply@reviews.apache.org>
References: <20170215220911.31018.98628@reviews.apache.org>
In-Reply-To: <20170215220911.31018.98628@reviews.apache.org>
Reply-To: Aurora ReviewBot <wfarner@apache.org>
archived-at: Wed, 15 Feb 2017 23:37:25 -0000

--===============1117553890645689364==
MIME-Version: 1.0
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: 7bit


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/56723/#review165781
-----------------------------------------------------------


Master (9ea8979) is red with this patch.
  ./build-support/jenkins/build.sh

  Test coverage missing for org/apache/aurora/scheduler/events/WebhookInfo
  Test coverage missing for org/apache/aurora/scheduler/storage/log/WriteAheadStorageForwarder
  Test coverage missing for org/apache/aurora/scheduler/storage/log/LogStorage$1
  Test coverage missing for org/apache/aurora/scheduler/storage/log/StreamManagerImpl$StreamTransactionImpl
  Test coverage missing for org/apache/aurora/scheduler/storage/log/EntrySerializer$EntrySerializerImpl$1
  Test coverage missing for org/apache/aurora/scheduler/storage/log/LogStorage$Settings
  Test coverage missing for org/apache/aurora/scheduler/storage/log/StreamManagerImpl
  Test coverage missing for org/apache/aurora/scheduler/storage/log/EntrySerializer$EntrySerializerImpl
  Test coverage missing for org/apache/aurora/scheduler/storage/log/LogStorage$ScheduledExecutorSchedulingService
  Test coverage missing for org/apache/aurora/scheduler/storage/log/LogStorageModule
  Test coverage missing for org/apache/aurora/scheduler/storage/log/LogStorage
  Test coverage missing for org/apache/aurora/scheduler/storage/log/SnapshotDeduplicator$SnapshotDeduplicatorImpl
  Test coverage missing for org/apache/aurora/scheduler/storage/log/Entries
  Test coverage missing for org/apache/aurora/scheduler/storage/log/LogManager
  Test coverage missing for org/apache/aurora/scheduler/storage/backup/StorageBackup$StorageBackupImpl$BackupConfig
  Test coverage missing for org/apache/aurora/scheduler/storage/backup/BackupModule
  Test coverage missing for org/apache/aurora/scheduler/SchedulerLifecycle$7
  Test coverage missing for org/apache/aurora/scheduler/SchedulerLifecycle$6
  Test coverage missing for org/apache/aurora/scheduler/SchedulerLifecycle$5
  Test coverage missing for org/apache/aurora/scheduler/SchedulerLifecycle$4
  Test coverage missing for org/apache/aurora/scheduler/SchedulerLifecycle$3
  Test coverage missing for org/apache/aurora/scheduler/SchedulerLifecycle$2
  Test coverage missing for org/apache/aurora/scheduler/SchedulerLifecycle$1
  Test coverage missing for org/apache/aurora/scheduler/TaskVars
  Test coverage missing for org/apache/aurora/scheduler/SchedulerLifecycle$SchedulerCandidateImpl
  Test coverage missing for org/apache/aurora/scheduler/SchedulerLifecycle$DefaultDelayedActions
  Test coverage missing for org/apache/aurora/scheduler/TierManager$TierManagerImpl$TierConfig
  Test coverage missing for org/apache/aurora/scheduler/TaskVars$Counter
  Test coverage missing for org/apache/aurora/scheduler/TaskVars$1
  Test coverage missing for org/apache/aurora/scheduler/SchedulerLifecycle
  Test coverage missing for org/apache/aurora/scheduler/storage/db/typehandlers/VolumeModeTypeHandler
  Test coverage missing for org/apache/aurora/scheduler/storage/db/typehandlers/MaintenanceModeTypeHandler

* Try:
Run with --stacktrace option to get the stack trace. Run with --info or --debug option to get more log output.
==============================================================================

BUILD FAILED

Total time: 1 hrs 26 mins 10.352 secs


I will refresh this build result if you post a review containing "@ReviewBot retry"

- Aurora ReviewBot


On Feb. 15, 2017, 10:09 p.m., Zameer Manji wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/56723/
> -----------------------------------------------------------
> 
> (Updated Feb. 15, 2017, 10:09 p.m.)
> 
> 
> Review request for Aurora, David McLaughlin and Santhosh Kumar Shanmugham.
> 
> 
> Bugs: AURORA-1890
>     https://issues.apache.org/jira/browse/AURORA-1890
> 
> 
> Repository: aurora
> 
> 
> Description
> -------
> 
> Currently the scheduler causes all coordinated ("pulsed") updates into
> ROLL_FORWARD_AWAITING_PULSE, or ROLL_BACK_AWAITING_PULSE on scheduler
> startup/recovery. This is because the last pulse timestamp is not durably stored
> and the timestamp of the last pulse is set to 0L (aka no pulse yet).
> 
> In cases where the pulse timeout is larger and the failover is fast or frequent,
> this casues many updates to unnecessarily transition into a pulse related state
> until the next pulse.
> 
> It is posible to avoid these uncessary transitons by traversing the job update
> events and finding the last PULSE -> * state transition. The timestamp of the *
> event indicates that a pulse was recieved at that point in time and can be used
> to inititalize the pulse sate on startup.
> 
> 
> Diffs
> -----
> 
>   api/src/main/thrift/org/apache/aurora/gen/api.thrift efd4e534c4ad90862d7a9fae437ed724da3a34dc 
>   src/main/java/org/apache/aurora/scheduler/base/Jobs.java 49e5b2cfc0b84bb0e0c95cca375cd0503f9dcdb5 
>   src/main/java/org/apache/aurora/scheduler/updater/JobUpdateControllerImpl.java 729c1234a2e27f1e756ddfd6a4e5a04fa20bbd7f 
>   src/test/java/org/apache/aurora/scheduler/updater/JobUpdaterIT.java ea0b89a232c2fc10f2183218b750bb0478d51a58 
> 
> Diff: https://reviews.apache.org/r/56723/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Zameer Manji
> 
>


--===============1117553890645689364==--