Mailing-List: contact reviews-help@aurora.apache.org; run by ezmlm
Precedence: bulk
Reply-To: reviews@aurora.apache.org
Content-Type: multipart/alternative;
 boundary="===============5553858704716189174=="
MIME-Version: 1.0
Subject: Re: Review Request 56629: Expose task pruning endpoint in aurora_admin
From: David McLaughlin <david@dmclaughlin.com>
To: Santhosh Kumar Shanmugham <santhoshkumar.s@gmail.com>,
 Stephan Erb <serb@apache.org>, Zameer Manji <zmanji@apache.org>
Cc: Aurora <reviews@aurora.apache.org>,
 Mehrdad Nurolahzade <mehrdad@apache.org>,
 Aurora ReviewBot <wfarner@apache.org>, Reza Motamedi <reza.motamedi@gmail.com>,
 David McLaughlin <david@dmclaughlin.com>
Date: Tue, 14 Feb 2017 07:06:08 -0000
Message-ID: <20170214070608.13056.13798@reviews.apache.org>
Auto-Submitted: auto-generated
Sender: David McLaughlin <noreply@reviews.apache.org>
References: <20170214054428.31018.34265@reviews.apache.org>
In-Reply-To: <20170214054428.31018.34265@reviews.apache.org>
Reply-To: David McLaughlin <david@dmclaughlin.com>
archived-at: Tue, 14 Feb 2017 07:06:11 -0000

--===============5553858704716189174==
MIME-Version: 1.0
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: 7bit


> On Feb. 14, 2017, 5:44 a.m., Santhosh Kumar Shanmugham wrote:
> > LGTM modulo my pervious comment,
> > 
> > "Since this command has the potential to hurt the Scheduler, should we make sure that atleast one of the filters is provided? Or force a minimum default limit to avoid operators from accidentally bringing down the scheduler?"

Not a huge fan of client-side limits like that. We should address how expensive task deletion is on the server side.


- David


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/56629/#review165456
-----------------------------------------------------------


On Feb. 14, 2017, 5:41 a.m., David McLaughlin wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/56629/
> -----------------------------------------------------------
> 
> (Updated Feb. 14, 2017, 5:41 a.m.)
> 
> 
> Review request for Aurora, Santhosh Kumar Shanmugham, Stephan Erb, and Zameer Manji.
> 
> 
> Repository: aurora
> 
> 
> Description
> -------
> 
> Expose task pruning endpoint in aurora_admin. Useful for scale testing in order to 'clean up' after a test run, but also useful in production if you have a bad actor inflating the size of your task index.
> 
> 
> Diffs
> -----
> 
>   RELEASE-NOTES.md 3e9880249aa40215a08424b58f85a634337cc67e 
>   api/src/main/thrift/org/apache/aurora/gen/api.thrift 6205c2ed1e2d5898a322de5bc2bcba6b2c0cd4b1 
>   src/main/java/org/apache/aurora/scheduler/thrift/SchedulerThriftInterface.java a211483caf59755b1f9b286b58f183e00db6eee6 
>   src/main/python/apache/aurora/admin/admin.py 070c348d2ca5db1edecf832efd9aa5481bddaa4b 
>   src/main/python/apache/aurora/client/api/__init__.py 1250ccd16f906eec08c159df3300d1b94b306d8e 
>   src/test/java/org/apache/aurora/scheduler/thrift/SchedulerThriftInterfaceTest.java 0cdd9829417bb3ef0215278a9458a3dd78a49a20 
>   src/test/python/apache/aurora/admin/test_admin.py 66abade378d3974dbf031a7bbed9cd6fc4f22d5f 
>   src/test/python/apache/aurora/client/api/test_scheduler_client.py fab97986dcecf7761e161f4074d5108a8c362e6e 
> 
> Diff: https://reviews.apache.org/r/56629/diff/
> 
> 
> Testing
> -------
> 
> Ran various combinations of task pruning via aurora_admin in Vagrant. Works as expected. 
> 
> Also:
> 
> ./pants test src/test/python/apache/aurora/admin::
> 
> 
> Thanks,
> 
> David McLaughlin
> 
>


--===============5553858704716189174==--