Return-Path: X-Original-To: archive-asf-public-internal@cust-asf2.ponee.io Delivered-To: archive-asf-public-internal@cust-asf2.ponee.io Received: from cust-asf.ponee.io (cust-asf.ponee.io [163.172.22.183]) by cust-asf2.ponee.io (Postfix) with ESMTP id A3F0B200C29 for ; Tue, 14 Feb 2017 03:26:44 +0100 (CET) Received: by cust-asf.ponee.io (Postfix) id A2707160B6C; Tue, 14 Feb 2017 02:26:44 +0000 (UTC) Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by cust-asf.ponee.io (Postfix) with SMTP id EDA22160B60 for ; Tue, 14 Feb 2017 03:26:43 +0100 (CET) Received: (qmail 74080 invoked by uid 500); 14 Feb 2017 02:26:43 -0000 Mailing-List: contact reviews-help@aurora.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: reviews@aurora.apache.org Delivered-To: mailing list reviews@aurora.apache.org Received: (qmail 74045 invoked by uid 99); 14 Feb 2017 02:26:42 -0000 Received: from reviews-vm.apache.org (HELO reviews.apache.org) (140.211.11.40) by apache.org (qpsmtpd/0.29) with ESMTP; Tue, 14 Feb 2017 02:26:42 +0000 Received: from reviews.apache.org (localhost [127.0.0.1]) by reviews.apache.org (Postfix) with ESMTP id C230431E909; Tue, 14 Feb 2017 02:26:41 +0000 (UTC) Content-Type: multipart/alternative; boundary="===============5147741498120395076==" MIME-Version: 1.0 Subject: Re: Review Request 53333: Add DSL and E2E changes for per task volume mounts. From: Zameer Manji To: Santhosh Kumar Shanmugham , Joshua Cohen , Stephan Erb Cc: Aurora , Zameer Manji , Jason Lai , Aurora ReviewBot Date: Tue, 14 Feb 2017 02:26:41 -0000 Message-ID: <20170214022641.13056.51257@reviews.apache.org> X-ReviewBoard-URL: https://reviews.apache.org/ Auto-Submitted: auto-generated Sender: Zameer Manji X-ReviewGroup: Aurora X-Auto-Response-Suppress: DR, RN, OOF, AutoReply X-ReviewRequest-URL: https://reviews.apache.org/r/53333/ X-Sender: Zameer Manji References: <20161102155924.1746.51000@reviews.apache.org> In-Reply-To: <20161102155924.1746.51000@reviews.apache.org> Reply-To: Zameer Manji X-ReviewRequest-Repository: aurora archived-at: Tue, 14 Feb 2017 02:26:44 -0000 --===============5147741498120395076== MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit > On Nov. 2, 2016, 8:59 a.m., Stephan Erb wrote: > > Ups, I forgot. The following seems to be missing: > > > > * Changelog entry > > * Enduser documentation (at least the configuration reference) Done. - Zameer ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53333/#review154573 ----------------------------------------------------------- On Oct. 31, 2016, 6:48 p.m., Zameer Manji wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/53333/ > ----------------------------------------------------------- > > (Updated Oct. 31, 2016, 6:48 p.m.) > > > Review request for Aurora, Joshua Cohen, Santhosh Kumar Shanmugham, and Stephan Erb. > > > Bugs: AURORA-1107 > https://issues.apache.org/jira/browse/AURORA-1107 > > > Repository: aurora > > > Description > ------- > > Enables the client DSL to set per task volume mounts. This also adds a E2E test that tests per task volume mounting. > > > Diffs > ----- > > examples/vagrant/upstart/aurora-scheduler.conf e68a801017ae02e0ed581129e12a645ccc1e35d4 > src/main/python/apache/aurora/config/schema/base.py 845163043b0b7b2f9e7aca14677ca9f094658551 > src/main/python/apache/aurora/config/thrift.py 3539469d243638c0acd08bf0859d0ce858d8977c > src/test/python/apache/aurora/config/test_thrift.py e213184739167e01f3614c20a809af39b3a6b3d6 > src/test/sh/org/apache/aurora/e2e/http/http_example.aurora c71fb81490863b44827bf090f6e5a6b28da94b93 > src/test/sh/org/apache/aurora/e2e/run-server.sh 1fe09090bfa3eeb0f6897e8c895782fb1ff949a1 > > Diff: https://reviews.apache.org/r/53333/diff/ > > > Testing > ------- > > sh ./src/test/sh/org/apache/aurora/e2e/test_end_to_end.sh > > > Thanks, > > Zameer Manji > > --===============5147741498120395076==--