aurora-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Zameer Manji <>
Subject Re: Review Request 57061: Enable Mesos HTTP API.
Date Mon, 27 Feb 2017 19:34:33 GMT

This is an automatically generated e-mail. To reply, visit:

(Updated Feb. 27, 2017, 11:34 a.m.)

Review request for Aurora, David McLaughlin, Mehrdad Nurolahzade, and Stephan Erb.



Bugs: AURORA-1887 and AURORA-1888

Repository: aurora


This patch completes the design doc[1] and enables operators to choose between
two V1 Mesos API implementations. The first is `V0Mesos` which offers the V1 API
backed by the scheduler driver and the second is `V1Mesos` which offers the V1
API backed by a new HTTP API implementation.

There are three sets of changes in this patch.

First, the V1 Mesos code requires a Scheduler callback with a different API. To
maximize code reuse, `MesosSchedulerImpl` was extended to implement the new
callback as well as the old callback. The code and tests were reshufled to
maxmize logic reuse.

Second, a new driver implementation using the new API was created. All of the
logic for the new driver is encapsulated in the
`VersionedSchedulerDriverService` class.

Third, some wiring changes were done to allow for Guice to do it's work and
allow for operators to select between the different driver implementations.

Unfortunately, due the interaction of Java 8 and Guice 3.0 I was forced to
disable the `SchedulerIT` test. I beleive the only way out is to upgrade to
Guice 4.0 which we cannot do yet. Since the e2e tests pass, it is clear that the
Guice bindings are valid.


Diffs (updated)

  config/legacy_untested_classes.txt ec3e934b2e0510b9339ac71182b78546cac0e7eb 
  examples/vagrant/upstart/aurora-scheduler.conf 49fdcbd8b7406a59ae7882473b9eddbfce3ece7c

  src/main/java/org/apache/aurora/scheduler/app/ e2ef9c30720698263106f22e3e24db5d0468b155

  src/main/java/org/apache/aurora/scheduler/app/ 805e9de9bc45396cb8fc6e33ddb3d7428312c608

  src/main/java/org/apache/aurora/scheduler/mesos/ e1a23590c795a489e753b77b0835d30d3be174b5

  src/main/java/org/apache/aurora/scheduler/mesos/ eb210962c54cd0d33e3760b32f5b0ca1a7079204

  src/main/java/org/apache/aurora/scheduler/mesos/ bc9e23b7410c00b7d5ffa4f23db93a51e9d0f405

  src/main/java/org/apache/aurora/scheduler/mesos/ 5519323079b2c957a23e093dcc77929148b4a59a

  src/main/java/org/apache/aurora/scheduler/mesos/ PRE-CREATION

  src/main/java/org/apache/aurora/scheduler/mesos/ PRE-CREATION

  src/test/java/org/apache/aurora/scheduler/app/ 05518048ca5518a007281269aa402a7d0710eb62

  src/test/java/org/apache/aurora/scheduler/mesos/ c599fe30bc903b3a3fb178df70a46d2421b6c45e

  src/test/java/org/apache/aurora/scheduler/thrift/ f2275c757ebfa52179e31b95bf0c02b6753fb7e3



The e2e test has been run three times, each time with a different driver option.


Zameer Manji

  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message