aurora-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Ilya Pronin <ipro...@twopensource.com>
Subject Review Request 57074: Fix scheduler_framework_disconnects stats
Date Sun, 26 Feb 2017 19:05:01 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/57074/
-----------------------------------------------------------

Review request for Aurora, Mehrdad Nurolahzade and Zameer Manji.


Bugs: AURORA-1860
    https://issues.apache.org/jira/browse/AURORA-1860


Repository: aurora


Description
-------

Refactoring in r/31550 has disabled incrementing scheduler_framework_disconnects stats. This
change brings it back.


Diffs
-----

  src/main/java/org/apache/aurora/scheduler/mesos/MesosSchedulerImpl.java 17301036e28d95ba90b3e4d8840d8a5641e49c46

  src/test/java/org/apache/aurora/scheduler/mesos/MesosSchedulerImplTest.java 9bb319bb04bb386d9792c3cc0017b039e8f25044


Diff: https://reviews.apache.org/r/57074/diff/


Testing
-------

Added a check to `MesosSchedulerImplTest.testDisconnected()`. Manually verified in Vagrant
by starting/stopping mesos-master and querying `/vars` endpoint.


Thanks,

Ilya Pronin


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message