aurora-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Zameer Manji <zma...@apache.org>
Subject Re: Review Request 56935: Fix for unnecessary object serializations
Date Wed, 22 Feb 2017 18:27:25 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/56935/#review166387
-----------------------------------------------------------



Could you please add to the RB description on what methodology you used to determine this
and what are the results of this patch?


Further, do you have any ideas on how we can prevent regressions?


src/main/java/org/apache/aurora/scheduler/storage/db/DbTaskStore.java (line 102)
<https://reviews.apache.org/r/56935/#comment238312>

    For here and below, I wonder if we could just extract out the message building and then
just switch on which log method to use.
    
    In the usual case we are going to be constructing the query either way since the default
logging is `INFO` so I think it's best to avid the duplicate object construction.


- Zameer Manji


On Feb. 22, 2017, 9:23 a.m., Mehrdad Nurolahzade wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/56935/
> -----------------------------------------------------------
> 
> (Updated Feb. 22, 2017, 9:23 a.m.)
> 
> 
> Review request for Aurora, David McLaughlin and Zameer Manji.
> 
> 
> Repository: aurora
> 
> 
> Description
> -------
> 
> This patch provides a fix for some unnecessary object serilizations that happen on high
frequency execution paths and contribute to scheduler's high object creation rate.
> 
> 
> Diffs
> -----
> 
>   src/main/java/org/apache/aurora/scheduler/events/Webhook.java 3e8e38abe29766f6fcf08707fba5df402c96a257

>   src/main/java/org/apache/aurora/scheduler/mesos/MesosSchedulerImpl.java 17301036e28d95ba90b3e4d8840d8a5641e49c46

>   src/main/java/org/apache/aurora/scheduler/mesos/MesosTaskFactory.java 0d639f66db456858278b0485c91c40975c3b45ac

>   src/main/java/org/apache/aurora/scheduler/resources/ResourceType.java c88428412d69e4202e7cceb1b608dc1809a9ccc0

>   src/main/java/org/apache/aurora/scheduler/storage/db/DbTaskStore.java a649a6e3d2f2d0aeaf6d7ac704ed24911c310a1e

>   src/main/java/org/apache/aurora/scheduler/storage/mem/MemTaskStore.java d89e715b1b08faf95f8b5788c9c28cbbb33af093

>   src/test/java/org/apache/aurora/scheduler/mesos/MesosSchedulerImplTest.java 9bb319bb04bb386d9792c3cc0017b039e8f25044

> 
> Diff: https://reviews.apache.org/r/56935/diff/
> 
> 
> Testing
> -------
> 
> ```./src/test/sh/org/apache/aurora/e2e/test_end_to_end.sh```
> 
> 
> Thanks,
> 
> Mehrdad Nurolahzade
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message