aurora-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Nicolás Donatucci <ndonatu...@medallia.com>
Subject Re: Review Request 56395: Change Resource Validation in ConfigurationManager so that it validates the Resource Set instead of deprecated fields
Date Wed, 15 Feb 2017 13:20:10 GMT


> On Feb. 14, 2017, 7:36 a.m., Reza Motamedi wrote:
> > src/main/java/org/apache/aurora/scheduler/resources/ResourceManager.java, line 153
> > <https://reviews.apache.org/r/56395/diff/1/?file=1626711#file1626711line153>
> >
> >     I don't get why this method name has package path in it? Is it just moved from
`ThriftBackFill`?

This is because in the ResourceManager there is the org.apache.mesos.v1.Protos.Resource already
imported. So there are two Resource objects in scope.


- Nicolás


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/56395/#review165471
-----------------------------------------------------------


On Feb. 7, 2017, 5:02 p.m., Nicolás Donatucci wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/56395/
> -----------------------------------------------------------
> 
> (Updated Feb. 7, 2017, 5:02 p.m.)
> 
> 
> Review request for Aurora, Stephan Erb and Zameer Manji.
> 
> 
> Repository: aurora
> 
> 
> Description
> -------
> 
> The Resource validation in ConfigurationManager is now done against the Resource set
instead of the NumCpus, RamMb and DiskMb fields.
> 
> To do this I moved the GetResource method from the ThriftBackfill to the ResourceManager
so it can be used in the ConfigurationManager without exposing it on the ThriftBackfill.
> 
> Related Issue: Aurora-1707
> 
> 
> Diffs
> -----
> 
>   src/main/java/org/apache/aurora/scheduler/configuration/ConfigurationManager.java 80f0aebd6de0c2d7c30a58ec09702d1c6d519787

>   src/main/java/org/apache/aurora/scheduler/resources/ResourceManager.java 9aa263a9cfae03a9a0c5bc7fe3a1405397d3009c

>   src/main/java/org/apache/aurora/scheduler/storage/log/ThriftBackfill.java c8838438ef5aa94fbcc407101e7f04abc75cd96e

> 
> Diff: https://reviews.apache.org/r/56395/diff/
> 
> 
> Testing
> -------
> 
> src/test/sh/org/apache/aurora/e2e/test_end_to_end.sh
> 
> 
> Thanks,
> 
> Nicolás Donatucci
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message