aurora-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Aurora ReviewBot <wfar...@apache.org>
Subject Re: Review Request 56690: [Patch 1/2] RFC for first patch implementing scheduling changes for Dynamic Reservations
Date Wed, 15 Feb 2017 00:24:08 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/56690/#review165608
-----------------------------------------------------------



This patch does not apply cleanly against master (0e9c086), do you need to rebase?

I will refresh this build result if you post a review containing "@ReviewBot retry"

- Aurora ReviewBot


On Feb. 14, 2017, 11:56 p.m., Dmitriy Shirchenko wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/56690/
> -----------------------------------------------------------
> 
> (Updated Feb. 14, 2017, 11:56 p.m.)
> 
> 
> Review request for Aurora, Mehrdad Nurolahzade, Stephan Erb, and Zameer Manji.
> 
> 
> Bugs: AURORA-1819
>     https://issues.apache.org/jira/browse/AURORA-1819
> 
> 
> Repository: aurora
> 
> 
> Description
> -------
> 
> This is an RFC (without tests) for dynamic reservations proposal. If there is consensus
on the approach, I will add tests. This patch was also tested locally and works as expected.
> 
> 
> Diffs
> -----
> 
>   src/jmh/java/org/apache/aurora/benchmark/SchedulingBenchmarks.java f2296a9d7a88be7e43124370edecfe64415df00f

>   src/jmh/java/org/apache/aurora/benchmark/fakes/FakeOfferManager.java fbd24ea4a58e28c14a343170de137c0e0ae437a2

>   src/main/java/org/apache/aurora/scheduler/TaskVars.java 676dfd9f9d7ee0633c05424f788fd0ab116976bb

>   src/main/java/org/apache/aurora/scheduler/TierInfo.java c45b949ae7946fc92d7e62f94696ddc4f0790cfa

>   src/main/java/org/apache/aurora/scheduler/TierManager.java c6ad2b1c48673ca2c14ddd308684d81ce536beca

>   src/main/java/org/apache/aurora/scheduler/base/InstanceKeys.java b12ac83168401c15fb1d30179ea8e4816f09cd3d

>   src/main/java/org/apache/aurora/scheduler/base/JobKeys.java 0136afb8f6049a6d88cd42b5e3f17d61fcd629d5

>   src/main/java/org/apache/aurora/scheduler/base/TaskTestUtil.java aba73005019c13ac943be9c53ac58c8ce5bfba94

>   src/main/java/org/apache/aurora/scheduler/events/NotifyingSchedulingFilter.java f6c759f03c4152ae93317692fc9db202fe251122

>   src/main/java/org/apache/aurora/scheduler/filter/SchedulingFilter.java bb1a960a4c77f48b0ceaa213bd27546551f384f9

>   src/main/java/org/apache/aurora/scheduler/filter/SchedulingFilterImpl.java 60097d91d836e2686d6e90571f13a2fbfd88ae14

>   src/main/java/org/apache/aurora/scheduler/mesos/MesosTaskFactory.java 3d5c3bd139206e970811aa95bd74b78987bb9cfe

>   src/main/java/org/apache/aurora/scheduler/offers/OfferManager.java 2b12696d0218a48d71e89df4d3a38c6bf84c74c7

>   src/main/java/org/apache/aurora/scheduler/offers/OfferSettings.java e16e36ed360ef9ca371df9084365ea88cfb6e7ce

>   src/main/java/org/apache/aurora/scheduler/offers/OffersModule.java 202cae96ffc5b49e638b973a273f7983137b5baf

>   src/main/java/org/apache/aurora/scheduler/resources/ResourceManager.java d751d017522c682a1373932e286ee7b4c447e2aa

>   src/main/java/org/apache/aurora/scheduler/scheduling/TaskScheduler.java 203f62bacc47470545d095e4d25f7e0f25990ed9

>   src/main/java/org/apache/aurora/scheduler/state/TaskAssigner.java a030cebea13d92766584643ddda33c50dec7bdbf

>   src/main/resources/org/apache/aurora/scheduler/tiers.json 34ddb1dc769a73115c209c9b2ee158cd364392d8

>   src/test/java/org/apache/aurora/scheduler/TierManagerTest.java 82e40d509d84c37a19b6a9ef942283d908833840

>   src/test/java/org/apache/aurora/scheduler/offers/OfferManagerImplTest.java fb8bd85be93280a9b8366b1398a1fa0a5817bb55

>   src/test/java/org/apache/aurora/scheduler/resources/AcceptedOfferTest.java 2777d7276d55cc0fe75e7470d0dc8182796d67f4

>   src/test/java/org/apache/aurora/scheduler/resources/ResourceManagerTest.java 133cd23427485ea329ef10489e5d4a0029cb54cd

>   src/test/java/org/apache/aurora/scheduler/resources/ResourceTestUtil.java 7dc8c179736fab93ca03e174b16e104ba0118127

>   src/test/java/org/apache/aurora/scheduler/state/TaskAssignerImplTest.java f8bb25b612ae42748205901dd4b8cfcdedf5b136

> 
> Diff: https://reviews.apache.org/r/56690/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Dmitriy Shirchenko
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message