aurora-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Santhosh Kumar Shanmugham <santhoshkuma...@gmail.com>
Subject Re: Review Request 56629: Expose task pruning endpoint in aurora_admin
Date Tue, 14 Feb 2017 05:06:39 GMT


> On Feb. 13, 2017, 5:54 p.m., Reza Motamedi wrote:
> > LGTM!
> > 
> > But, should we test this in the test cluster? At least to check the effect of _limit_?
> 
> David McLaughlin wrote:
>     I did test this in Vagrant. All the options work correctly.
> 
> David McLaughlin wrote:
>     Weird, verifying the StateManager change in Vagrant and now limit does not appear
to work.

Weird - `TaskQuery.getLimit()` is only used in `ReadOnlySchedulerImpl.getTasks`. (I wonder
how your previous test passed?) 

Even this implementation is of limit in `getTasks` is inefficient, since we fetch all the
tasks from the store and then apply the limit. Limit needs to be applied as part of `TaskStore.queryFilter`.


- Santhosh Kumar


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/56629/#review165425
-----------------------------------------------------------


On Feb. 13, 2017, 8:28 p.m., David McLaughlin wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/56629/
> -----------------------------------------------------------
> 
> (Updated Feb. 13, 2017, 8:28 p.m.)
> 
> 
> Review request for Aurora, Santhosh Kumar Shanmugham, Stephan Erb, and Zameer Manji.
> 
> 
> Repository: aurora
> 
> 
> Description
> -------
> 
> Expose task pruning endpoint in aurora_admin. Useful for scale testing in order to 'clean
up' after a test run, but also useful in production if you have a bad actor inflating the
size of your task index.
> 
> 
> Diffs
> -----
> 
>   api/src/main/thrift/org/apache/aurora/gen/api.thrift 6205c2ed1e2d5898a322de5bc2bcba6b2c0cd4b1

>   src/main/java/org/apache/aurora/scheduler/thrift/SchedulerThriftInterface.java a211483caf59755b1f9b286b58f183e00db6eee6

>   src/main/python/apache/aurora/admin/admin.py 070c348d2ca5db1edecf832efd9aa5481bddaa4b

>   src/main/python/apache/aurora/client/api/__init__.py 1250ccd16f906eec08c159df3300d1b94b306d8e

>   src/test/java/org/apache/aurora/scheduler/thrift/SchedulerThriftInterfaceTest.java
0cdd9829417bb3ef0215278a9458a3dd78a49a20 
>   src/test/python/apache/aurora/admin/test_admin.py 66abade378d3974dbf031a7bbed9cd6fc4f22d5f

>   src/test/python/apache/aurora/client/api/test_scheduler_client.py fab97986dcecf7761e161f4074d5108a8c362e6e

> 
> Diff: https://reviews.apache.org/r/56629/diff/
> 
> 
> Testing
> -------
> 
> Ran various combinations of task pruning via aurora_admin in Vagrant. Works as expected.

> 
> Also:
> 
> ./pants test src/test/python/apache/aurora/admin::
> 
> 
> Thanks,
> 
> David McLaughlin
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message