aurora-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Zameer Manji <zma...@apache.org>
Subject Re: Review Request 56523: Displaying update id after 'Killed for job update' message for the update that resulted in the task getting killed
Date Mon, 13 Feb 2017 20:10:27 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/56523/#review165385
-----------------------------------------------------------


Ship it!




LGTM, thanks for your contribution.

- Zameer Manji


On Feb. 13, 2017, 12:09 p.m., Abhishek Jain wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/56523/
> -----------------------------------------------------------
> 
> (Updated Feb. 13, 2017, 12:09 p.m.)
> 
> 
> Review request for Aurora, Stephan Erb and Zameer Manji.
> 
> 
> Bugs: AURORA-1806
>     https://issues.apache.org/jira/browse/AURORA-1806
> 
> 
> Repository: aurora
> 
> 
> Description
> -------
> 
> Displaying update id after 'Killed for job update' message for the update that resulted
in the task getting killed.
> 
> 
> Diffs
> -----
> 
>   src/main/java/org/apache/aurora/scheduler/updater/InstanceActionHandler.java 11ffa663e4e0fa5fda0ebb343d11d2485a83c7c6

>   src/main/java/org/apache/aurora/scheduler/updater/JobUpdateControllerImpl.java 80e97d7c4b655ec35122fe16503e049575f08cdd

>   src/test/java/org/apache/aurora/scheduler/updater/AddTaskTest.java 56c94b5caf414861212f673a27b84d46c07332e6

>   src/test/java/org/apache/aurora/scheduler/updater/KillTaskTest.java e5935f65924e7d9a2491cac8f4c1f575ec657776

> 
> Diff: https://reviews.apache.org/r/56523/diff/
> 
> 
> Testing
> -------
> 
> Tests:
> ------
> aurora job create devcluster/www-data/devel/hello_world my_jobs/new_hello_world_job.aurora
> aurora update start devcluster/www-data/devel/hello_world my_jobs/new_hello_world_job_update.aurora
> 
> Completed Task status information:
> -----------------------------------
> 3 minutes ago - KILLED : Instructed to kill task.
> 02/09 19:52:53 LOCAL • PENDING
> 02/09 19:52:53 LOCAL • ASSIGNED
> 02/09 19:52:54 LOCAL • STARTING • Initializing sandbox.
> 02/09 19:52:55 LOCAL • RUNNING • No health-check defined, task is assumed healthy.
> 02/09 19:53:08 LOCAL • KILLING • Killed for job update : 900256bb-9cad-41d6-b330-d74a751239bf
> 02/09 19:53:10 LOCAL • KILLED • Instructed to kill task.
> 
> Build tests:
> -------------
> ./build-support/jenkins/build.sh
> ./src/test/sh/org/apache/aurora/e2e/test_end_to_end.sh
> 
> 
> Thanks,
> 
> Abhishek Jain
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message