aurora-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Abhishek Jain <ajai...@binghamton.edu>
Subject Re: Review Request 56523: Displaying update id after 'Killed for job update' message for the update that resulted in the task getting killed
Date Fri, 10 Feb 2017 21:36:09 GMT


> On Feb. 10, 2017, 7:36 p.m., Aurora ReviewBot wrote:
> > Master (ad3377a) is red with this patch.
> >   ./build-support/jenkins/build.sh
> > 
> >   Test coverage missing for org/apache/aurora/scheduler/discovery/ServiceDiscoveryModule
> >   Test coverage missing for org/apache/aurora/scheduler/reconciliation/TaskTimeout
> >   Test coverage missing for org/apache/aurora/scheduler/reconciliation/TaskTimeout$TimedOutTaskHandler
> >   Test coverage missing for org/apache/aurora/scheduler/cron/quartz/AuroraCronJob$CronBatchWorker
> >   Test coverage missing for org/apache/aurora/scheduler/scheduling/TaskGroups$TaskGroupBatchWorker
> >   Test coverage missing for org/apache/aurora/scheduler/scheduling/TaskGroups$1
> >   Test coverage missing for org/apache/aurora/scheduler/scheduling/TaskGroups
> >   Test coverage missing for org/apache/aurora/scheduler/storage/mem/MemTaskStore$SecondaryIndex$2
> >   Test coverage missing for org/apache/aurora/scheduler/storage/mem/MemTaskStore$SecondaryIndex$1
> >   Test coverage missing for org/apache/aurora/scheduler/mesos/TaskStatusStats$3
> >   Test coverage missing for org/apache/aurora/scheduler/mesos/TaskStatusStats$2
> >   Test coverage missing for org/apache/aurora/scheduler/mesos/TaskStatusStats$1
> >   Test coverage missing for org/apache/aurora/scheduler/mesos/TaskStatusStats
> >   Test coverage missing for org/apache/aurora/scheduler/thrift/AuditMessages
> >   Test coverage missing for org/apache/aurora/scheduler/preemptor/PendingTaskProcessor
> >   Test coverage missing for org/apache/aurora/scheduler/preemptor/PendingTaskProcessor$1
> >   Test coverage missing for org/apache/aurora/scheduler/preemptor/PendingTaskProcessor$2
> >   Test coverage missing for org/apache/aurora/scheduler/preemptor/PendingTaskProcessor$3
> >   Test coverage missing for org/apache/aurora/scheduler/preemptor/PreemptorModule$PreemptorService
> >   Test coverage missing for org/apache/aurora/scheduler/events/WebhookModule
> >   Test coverage missing for org/apache/aurora/scheduler/events/Webhook
> >   Test coverage missing for org/apache/aurora/scheduler/events/WebhookInfo
> >   Test coverage missing for org/apache/aurora/scheduler/storage/log/EntrySerializer$EntrySerializerImpl$1
> >   Test coverage missing for org/apache/aurora/scheduler/storage/log/LogStorage$Settings
> >   Test coverage missing for org/apache/aurora/scheduler/storage/log/LogStorage$ScheduledExecutorSchedulingService
> >   Test coverage missing for org/apache/aurora/scheduler/storage/log/LogStorageModule
> >   Test coverage missing for org/apache/aurora/scheduler/storage/backup/BackupModule
> >   Test coverage missing for org/apache/aurora/scheduler/TaskVars
> >   Test coverage missing for org/apache/aurora/scheduler/SchedulerLifecycle$DefaultDelayedActions
> >   Test coverage missing for org/apache/aurora/scheduler/TierManager$TierManagerImpl$TierConfig
> >   Test coverage missing for org/apache/aurora/scheduler/TaskVars$Counter
> >   Test coverage missing for org/apache/aurora/scheduler/TaskVars$1
> > 
> > * Try:
> > Run with --stacktrace option to get the stack trace. Run with --info or --debug
option to get more log output.
> > ==============================================================================
> > 
> > BUILD FAILED
> > 
> > Total time: 5 mins 1.673 secs
> > 
> > 
> > I will refresh this build result if you post a review containing "@ReviewBot retry"

@ReviewBot retry


- Abhishek


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/56523/#review165152
-----------------------------------------------------------


On Feb. 10, 2017, 7:24 p.m., Abhishek Jain wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/56523/
> -----------------------------------------------------------
> 
> (Updated Feb. 10, 2017, 7:24 p.m.)
> 
> 
> Review request for Aurora, Stephan Erb and Zameer Manji.
> 
> 
> Repository: aurora
> 
> 
> Description
> -------
> 
> Displaying update id after 'Killed for job update' message for the update that resulted
in the task getting killed.
> 
> 
> Diffs
> -----
> 
>   src/main/java/org/apache/aurora/scheduler/updater/InstanceActionHandler.java 11ffa663e4e0fa5fda0ebb343d11d2485a83c7c6

>   src/main/java/org/apache/aurora/scheduler/updater/JobUpdateControllerImpl.java 80e97d7c4b655ec35122fe16503e049575f08cdd

>   src/test/java/org/apache/aurora/scheduler/updater/AddTaskTest.java 56c94b5caf414861212f673a27b84d46c07332e6

>   src/test/java/org/apache/aurora/scheduler/updater/KillTaskTest.java e5935f65924e7d9a2491cac8f4c1f575ec657776

> 
> Diff: https://reviews.apache.org/r/56523/diff/
> 
> 
> Testing
> -------
> 
> Tests:
> ------
> aurora job create devcluster/www-data/devel/hello_world my_jobs/new_hello_world_job.aurora
> aurora update start devcluster/www-data/devel/hello_world my_jobs/new_hello_world_job_update.aurora
> 
> Completed Task status information:
> -----------------------------------
> 3 minutes ago - KILLED : Instructed to kill task.
> 02/09 19:52:53 LOCAL • PENDING
> 02/09 19:52:53 LOCAL • ASSIGNED
> 02/09 19:52:54 LOCAL • STARTING • Initializing sandbox.
> 02/09 19:52:55 LOCAL • RUNNING • No health-check defined, task is assumed healthy.
> 02/09 19:53:08 LOCAL • KILLING • Killed for job update : 900256bb-9cad-41d6-b330-d74a751239bf
> 02/09 19:53:10 LOCAL • KILLED • Instructed to kill task.
> 
> Build tests:
> -------------
> ./build-support/jenkins/build.sh
> ./src/test/sh/org/apache/aurora/e2e/test_end_to_end.sh
> 
> 
> Thanks,
> 
> Abhishek Jain
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message