aurora-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Zameer Manji <zma...@apache.org>
Subject Review Request 56265: Move Aurora to v1 Protobufs.
Date Fri, 03 Feb 2017 03:12:59 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/56265/
-----------------------------------------------------------

Review request for Aurora, Mehrdad Nurolahzade and Stephan Erb.


Bugs: AURORA-1886
    https://issues.apache.org/jira/browse/AURORA-1886


Repository: aurora


Description
-------

This is the first step in moving Aurora to the V1 API from Mesos. This patch
moves most of the code to v1 Protobufs. This means all peices of code that do
not interact with Mesos now handle only v1 Protobufs.

Classes that interact with Mesos directly are:

* `org.apache.aurora.scheduler.mesos.SchedulerDriverService`
* `org.apache.aurora.scheduler.mesos.MesosSchedulerImpl`
* `org.apache.aurora.scheduler.mesos.DriverFactoryImpl`

These classes handle unversioned Protobufs and use the `ProtosConversion` class
to convert them to v1 Protobufs that can be safely passed to the rest of the
code.


Diffs
-----

  src/main/java/org/apache/aurora/scheduler/HostOffer.java ad30bf978ae5aa278fa9b5e01294c43892b08762

  src/main/java/org/apache/aurora/scheduler/SchedulerModule.java 2ec3967ddb1d470cf681de062a6400f647978185

  src/main/java/org/apache/aurora/scheduler/TaskStatusHandler.java 3e132ee8595b9b771adcc9580af213c1a4439e69

  src/main/java/org/apache/aurora/scheduler/TaskStatusHandlerImpl.java 6afafe875fc31982bc1afcebe40e4953172a7984

  src/main/java/org/apache/aurora/scheduler/base/Conversions.java d08b6cf1c7f9e49fefd3b560aeba9bb4a53a20fc

  src/main/java/org/apache/aurora/scheduler/base/Numbers.java 1b278e29555cf4dbaba63b7b87e8b21ae78f9786

  src/main/java/org/apache/aurora/scheduler/base/TaskTestUtil.java aba73005019c13ac943be9c53ac58c8ce5bfba94

  src/main/java/org/apache/aurora/scheduler/configuration/executor/ExecutorConfig.java 32bafb2b3ef4ea64fa0a5e3ffc43b47361fd3358

  src/main/java/org/apache/aurora/scheduler/configuration/executor/ExecutorModule.java 0d6a8c9acfbf4a0838fa580da09ce4c50a1b0761

  src/main/java/org/apache/aurora/scheduler/configuration/executor/ExecutorSettingsLoader.java
18ff2e2baebe1784bc31bc7f3a685282a2bed915 
  src/main/java/org/apache/aurora/scheduler/configuration/executor/Executors.java 6ac2d006c45393592e3e8b4ed94f99500f6518b2

  src/main/java/org/apache/aurora/scheduler/events/PubsubEvent.java 70b5470b9dad1af838b5222cae5ac86487e2f2e4

  src/main/java/org/apache/aurora/scheduler/mesos/CommandLineDriverSettingsModule.java 36c69be9ccf152c5d74466a08ddca8029b4a13c9

  src/main/java/org/apache/aurora/scheduler/mesos/Driver.java bb208ea7f77402a07aef162930288219595054a2

  src/main/java/org/apache/aurora/scheduler/mesos/DriverFactory.java 92d8924aa182ae272fd394ce68dcec0bf35a118d

  src/main/java/org/apache/aurora/scheduler/mesos/DriverFactoryImpl.java a5f5e9940c467b7f8584254b4bfefa3b5d059abe

  src/main/java/org/apache/aurora/scheduler/mesos/DriverSettings.java 85d471ff88618665a377182b5b1c208278e3ccea

  src/main/java/org/apache/aurora/scheduler/mesos/MesosSchedulerImpl.java 7b2614f3f2b552235cf93ca285bcf9c999457e46

  src/main/java/org/apache/aurora/scheduler/mesos/MesosTaskFactory.java 3d5c3bd139206e970811aa95bd74b78987bb9cfe

  src/main/java/org/apache/aurora/scheduler/mesos/ProtosConversion.java PRE-CREATION 
  src/main/java/org/apache/aurora/scheduler/mesos/SchedulerDriverService.java c89be79f5610a56477fbbd4ae8b2475a682456b6

  src/main/java/org/apache/aurora/scheduler/mesos/TaskStatusStats.java 5573638f0a18ae6cdd84f648160d0e63c27f7510

  src/main/java/org/apache/aurora/scheduler/mesos/TestExecutorSettings.java fe54411906c2d5546266488579e30c09af5bdc56

  src/main/java/org/apache/aurora/scheduler/offers/OfferManager.java 2b12696d0218a48d71e89df4d3a38c6bf84c74c7

  src/main/java/org/apache/aurora/scheduler/preemptor/PendingTaskProcessor.java dad1cbbe6d3d4a16fda5530c56480c1b55a81324

  src/main/java/org/apache/aurora/scheduler/preemptor/Preemptor.java 6b807e0335dfc6295b3ea96ebcdab858bb40f57d

  src/main/java/org/apache/aurora/scheduler/reconciliation/TaskReconciler.java 003fe5389e50c97bde3bf4fe62b5a43f5caa1ebe

  src/main/java/org/apache/aurora/scheduler/resources/AcceptedOffer.java c100e80303036f6f384928c915c8bea35b4e09d1

  src/main/java/org/apache/aurora/scheduler/resources/MesosResourceConverter.java 31235069410170d1c9d6583a91714836a62dd407

  src/main/java/org/apache/aurora/scheduler/resources/ResourceManager.java d751d017522c682a1373932e286ee7b4c447e2aa

  src/main/java/org/apache/aurora/scheduler/resources/ResourceMapper.java dc57d57d2b7ed885db562a94132b85771b4ae084

  src/main/java/org/apache/aurora/scheduler/resources/ResourceType.java 178466f1e4e640929bce64e8215118f336b7d0eb

  src/main/java/org/apache/aurora/scheduler/state/StateManager.java d395104af84477b03649ddd65276fbd1dc1e9210

  src/main/java/org/apache/aurora/scheduler/state/StateManagerImpl.java 7b70c41815792ca085436565a2a6267d04e99980

  src/main/java/org/apache/aurora/scheduler/state/TaskAssigner.java a030cebea13d92766584643ddda33c50dec7bdbf

  src/main/java/org/apache/aurora/scheduler/storage/AttributeStore.java 981bdcf665fdfa710608c57e7b7817d286dab373

  src/test/java/org/apache/aurora/ProtobufsTest.java 6c388854ac31ba8db809efed4277878c25b085f8

  src/test/java/org/apache/aurora/scheduler/TaskStatusHandlerImplTest.java b28d703ab58f9c47a27ad6d1c407af62b17012d4

  src/test/java/org/apache/aurora/scheduler/app/SchedulerIT.java 29a3b4a57925f31e59a49d4bfa630e724cadcb04

  src/test/java/org/apache/aurora/scheduler/app/local/FakeMaster.java 965bfa7702a6d7308c767f13b2740f1ad94248a0

  src/test/java/org/apache/aurora/scheduler/app/local/LocalSchedulerMain.java 80fd223b241b43142fb346d3a0a1314f8a04705e

  src/test/java/org/apache/aurora/scheduler/app/local/simulator/ClusterSimulatorModule.java
8c0d179afac37165a26e4cc451acbc049a70d6d6 
  src/test/java/org/apache/aurora/scheduler/app/local/simulator/FakeSlaves.java d8724e4aad44b609383fcbaac0e62c7ff9e0bdd1

  src/test/java/org/apache/aurora/scheduler/app/local/simulator/events/OfferAccepted.java
2fd9c5ee73595177972bf980ba89a98b5a8e80c7 
  src/test/java/org/apache/aurora/scheduler/base/ConversionsTest.java 9f94a98b2c4d59b8d1ee75700e29de649d59108b

  src/test/java/org/apache/aurora/scheduler/configuration/executor/ExecutorModuleTest.java
d597b13b95e25e768d7c5010e4f6888c8e2d9c5a 
  src/test/java/org/apache/aurora/scheduler/configuration/executor/ExecutorSettingsLoaderTest.java
b8cfbaa3f3e5e03a7e405d5eeca12bb9b7587207 
  src/test/java/org/apache/aurora/scheduler/http/OffersTest.java add0eb8f861a36551ed87ba13a75b82c5cd5bdfa

  src/test/java/org/apache/aurora/scheduler/mesos/CommandLineDriverSettingsModuleTest.java
ffc960c2698013c93765765dc7fc4c6c624e3653 
  src/test/java/org/apache/aurora/scheduler/mesos/MesosSchedulerImplTest.java ed48934c3954a4a092158f1f25f98c0eb7782b37

  src/test/java/org/apache/aurora/scheduler/mesos/MesosTaskFactoryImplTest.java 234acc13164a05b6886bcdd2bb9296397ec0b903

  src/test/java/org/apache/aurora/scheduler/mesos/ProtosConversionTest.java PRE-CREATION 
  src/test/java/org/apache/aurora/scheduler/mesos/SchedulerDriverServiceTest.java 35620a144b5eec5ebe7633d8eb4c4e554868e5ea

  src/test/java/org/apache/aurora/scheduler/mesos/TaskStatusStatsTest.java a48c85bcedb537f8081fb00abdca6e210083e7cf

  src/test/java/org/apache/aurora/scheduler/offers/OfferManagerImplTest.java fb8bd85be93280a9b8366b1398a1fa0a5817bb55

  src/test/java/org/apache/aurora/scheduler/offers/Offers.java c0899b069fe6f7e8160344f894ba00039e95852b

  src/test/java/org/apache/aurora/scheduler/preemptor/PendingTaskProcessorTest.java 5c115f3f7840b93ab05ad9aeee4dff417e5c5a5e

  src/test/java/org/apache/aurora/scheduler/preemptor/PreemptionVictimFilterTest.java 64da234aa6b0569ded365badd06bd0b780351c4d

  src/test/java/org/apache/aurora/scheduler/preemptor/PreemptorImplTest.java 3b932c9858cd6222cb61f63800566226bf1acf4d

  src/test/java/org/apache/aurora/scheduler/reconciliation/TaskReconcilerTest.java cc6f44df1afc0c8ebb1b74e13a930ce012503f09

  src/test/java/org/apache/aurora/scheduler/resources/AcceptedOfferTest.java 2777d7276d55cc0fe75e7470d0dc8182796d67f4

  src/test/java/org/apache/aurora/scheduler/resources/MesosResourceConverterTest.java 2f67ef4f40ebbb9910c806fa8d48933b8d6ed272

  src/test/java/org/apache/aurora/scheduler/resources/PortMapperTest.java 244c9de966311789e97a5fb1a5ab6625c232c7ac

  src/test/java/org/apache/aurora/scheduler/resources/ResourceManagerTest.java 133cd23427485ea329ef10489e5d4a0029cb54cd

  src/test/java/org/apache/aurora/scheduler/resources/ResourceTestUtil.java 7dc8c179736fab93ca03e174b16e104ba0118127

  src/test/java/org/apache/aurora/scheduler/state/StateManagerImplTest.java fbcc4003f7647580b859f4dc08a16c3e471a8f18

  src/test/java/org/apache/aurora/scheduler/state/TaskAssignerImplTest.java f8bb25b612ae42748205901dd4b8cfcdedf5b136

  src/test/java/org/apache/aurora/scheduler/stats/AsyncStatsModuleTest.java 75bac6f238a619c41903007babd4a6e20aaeaa1e

  src/test/java/org/apache/aurora/scheduler/thrift/ThriftIT.java 86861e1bd4ca5b920808abf419bc13f83961b836


Diff: https://reviews.apache.org/r/56265/diff/


Testing
-------


Thanks,

Zameer Manji


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message