Return-Path: X-Original-To: archive-asf-public-internal@cust-asf2.ponee.io Delivered-To: archive-asf-public-internal@cust-asf2.ponee.io Received: from cust-asf.ponee.io (cust-asf.ponee.io [163.172.22.183]) by cust-asf2.ponee.io (Postfix) with ESMTP id ADED5200C0C for ; Mon, 30 Jan 2017 15:32:36 +0100 (CET) Received: by cust-asf.ponee.io (Postfix) id AA2F5160B4D; Mon, 30 Jan 2017 14:32:36 +0000 (UTC) Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by cust-asf.ponee.io (Postfix) with SMTP id 00237160B41 for ; Mon, 30 Jan 2017 15:32:35 +0100 (CET) Received: (qmail 44837 invoked by uid 500); 30 Jan 2017 14:32:35 -0000 Mailing-List: contact reviews-help@aurora.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: reviews@aurora.apache.org Delivered-To: mailing list reviews@aurora.apache.org Received: (qmail 44809 invoked by uid 99); 30 Jan 2017 14:32:34 -0000 Received: from reviews-vm.apache.org (HELO reviews.apache.org) (140.211.11.40) by apache.org (qpsmtpd/0.29) with ESMTP; Mon, 30 Jan 2017 14:32:34 +0000 Received: from reviews.apache.org (localhost [127.0.0.1]) by reviews.apache.org (Postfix) with ESMTP id 0EB7A31953F; Mon, 30 Jan 2017 14:32:33 +0000 (UTC) Content-Type: multipart/alternative; boundary="===============3908643067603450039==" MIME-Version: 1.0 Subject: Re: Review Request 56058: Fix pendingTasks endpoint in case of multiple TaskGroups per job From: Pradyumna Kaushik To: Santhosh Kumar Shanmugham , Pradyumna Kaushik Cc: Aurora ReviewBot , Stephan Erb , Aurora Date: Mon, 30 Jan 2017 14:32:33 -0000 Message-ID: <20170130143233.5717.948@reviews.apache.org> X-ReviewBoard-URL: https://reviews.apache.org/ Auto-Submitted: auto-generated Sender: Pradyumna Kaushik X-ReviewGroup: Aurora X-Auto-Response-Suppress: DR, RN, OOF, AutoReply X-ReviewRequest-URL: https://reviews.apache.org/r/56058/ X-Sender: Pradyumna Kaushik References: <20170130143201.5717.89062@reviews.apache.org> In-Reply-To: <20170130143201.5717.89062@reviews.apache.org> Reply-To: Pradyumna Kaushik X-ReviewRequest-Repository: aurora archived-at: Mon, 30 Jan 2017 14:32:36 -0000 --===============3908643067603450039== MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit > On Jan. 30, 2017, 2:32 p.m., Pradyumna Kaushik wrote: > > Ship it! - Pradyumna ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/56058/#review163518 ----------------------------------------------------------- On Jan. 30, 2017, 12:55 p.m., Stephan Erb wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/56058/ > ----------------------------------------------------------- > > (Updated Jan. 30, 2017, 12:55 p.m.) > > > Review request for Aurora, Pradyumna Kaushik and Santhosh Kumar Shanmugham. > > > Bugs: AURORA-1879 > https://issues.apache.org/jira/browse/AURORA-1879 > > > Repository: aurora > > > Description > ------- > > Central idea of this patch is to change the return value of `getPendingReasons` from a map keyed by JobKey to a map keyed by `TaskGroupKey`. This prevents the `IllegalArgumentException` during the map construction. > > > Diffs > ----- > > src/main/java/org/apache/aurora/scheduler/http/PendingTasks.java 457107090351330e68941b039ce87b9a3a124971 > src/main/java/org/apache/aurora/scheduler/metadata/NearestFit.java 1c015a20853b1bc02033bdc925d3d8fc55896de1 > src/test/java/org/apache/aurora/scheduler/http/PendingTasksTest.java b71669f7aed58ea87bd3a23e45ff74efa1420aec > src/test/java/org/apache/aurora/scheduler/metadata/NearestFitTest.java 195d083166edcb0531b221dc5088216bd6a387f3 > > Diff: https://reviews.apache.org/r/56058/diff/ > > > Testing > ------- > > ./gradlew -Pq build > > > Thanks, > > Stephan Erb > > --===============3908643067603450039==--