Mailing-List: contact reviews-help@aurora.apache.org; run by ezmlm
Precedence: bulk
Reply-To: reviews@aurora.apache.org
Content-Type: multipart/alternative;
 boundary="===============6160674978237853941=="
MIME-Version: 1.0
Subject: Re: Review Request 55089: AURORA-1826	Expose Thrift server request
 workload stats
From: Mehrdad Nurolahzade <mehrdad@nurolahzade.com>
To: David McLaughlin <david@dmclaughlin.com>, Stephan Erb <serb@apache.org>
Cc: Aurora ReviewBot <wfarner@apache.org>,
 Mehrdad Nurolahzade <mehrdad@nurolahzade.com>,
 Reza Motamedi <reza.motamedi@gmail.com>, Aurora <reviews@aurora.apache.org>
Date: Wed, 25 Jan 2017 23:18:55 -0000
Message-ID: <20170125231855.13409.87609@reviews.apache.org>
Auto-Submitted: auto-generated
Sender: Mehrdad Nurolahzade <noreply@reviews.apache.org>
References: <20170125231103.13408.71768@reviews.apache.org>
In-Reply-To: <20170125231103.13408.71768@reviews.apache.org>
Reply-To: Mehrdad Nurolahzade <mehrdad@nurolahzade.com>
archived-at: Wed, 25 Jan 2017 23:18:59 -0000

--===============6160674978237853941==
MIME-Version: 1.0
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: 7bit


> On Jan. 25, 2017, 3:11 p.m., Stephan Erb wrote:
> > src/main/java/org/apache/aurora/scheduler/thrift/SchedulerThriftInterface.java, line 427
> > <https://reviews.apache.org/r/55089/diff/2/?file=1593704#file1593704line427>
> >
> >     This annotation can be very missleading when adding a new API endpoint. If you add it to a method it will only be tracked if one has edited in a completly different part of the code. Would it be possible to write something like the following?
> >     
> >     ```
> >         @ThriftWorkload(result -> result.getJobSummaryResult().getSummariesSize())
> >     ```

I like it! Let me try.


- Mehrdad


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/55089/#review163042
-----------------------------------------------------------


On Dec. 29, 2016, 9:58 p.m., Mehrdad Nurolahzade wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/55089/
> -----------------------------------------------------------
> 
> (Updated Dec. 29, 2016, 9:58 p.m.)
> 
> 
> Review request for Aurora, David McLaughlin and Stephan Erb.
> 
> 
> Bugs: AURORA-1826
>     https://issues.apache.org/jira/browse/AURORA-1826
> 
> 
> Repository: aurora
> 
> 
> Description
> -------
> 
> AURORA-1826	Expose Thrift server request workload stats
> 
> 
> Diffs
> -----
> 
>   src/main/java/org/apache/aurora/scheduler/thrift/SchedulerThriftInterface.java 16b1b52f8691d978a9ec1bf7aa0c9716b3484cf0 
>   src/main/java/org/apache/aurora/scheduler/thrift/aop/Measured.java PRE-CREATION 
>   src/main/java/org/apache/aurora/scheduler/thrift/aop/ThriftStatsExporterInterceptor.java d57f910d8f9bbe5c24aec960e88d03702bc353da 
>   src/test/java/org/apache/aurora/scheduler/thrift/SchedulerThriftInterfaceTest.java b28cd2489a52041a8e7e53f298fad8d8cd29406f 
>   src/test/java/org/apache/aurora/scheduler/thrift/aop/ThriftStatsExporterInterceptorTest.java 9c40ec51c28c8c57365dc21c3cd7391a3894784c 
> 
> Diff: https://reviews.apache.org/r/55089/diff/
> 
> 
> Testing
> -------
> 
> ```
> curl 192.168.33.7:8081/vars | grep thrift_workload
>   % Total    % Received % Xferd  Average Speed   Time    Time     Time  Current
>                                  Dload  Upload   Total   Spent    Left  Speed
> 100 41334    0 41334    0     0  3695k      0 --:--:-- --:--:-- --:--:-- 4036k
> thrift_workload_addInstances 0
> thrift_workload_createJob 0
> thrift_workload_createOrUpdateCronTemplate 0
> thrift_workload_drainHosts 0
> thrift_workload_endMaintenance 0
> thrift_workload_getConfigSummary 0
> thrift_workload_getJobSummary 0
> thrift_workload_getJobUpdateDetails 0
> thrift_workload_getJobUpdateSummaries 0
> thrift_workload_getJobs 0
> thrift_workload_getPendingReason 0
> thrift_workload_getRoleSummary 0
> thrift_workload_getTaskStatus 0
> thrift_workload_getTasksWithoutConfigs 0
> thrift_workload_killTasks 0
> thrift_workload_maintenanceStatus 0
> thrift_workload_restartShards 0
> thrift_workload_rewriteConfigs 0
> thrift_workload_startJobUpdate 0
> thrift_workload_startMaintenance 0
> ```
> 
> ```
> ./src/test/sh/org/apache/aurora/e2e/test_end_to_end.sh
> 
> ...
> 
> *** OK (All tests passed) ***
> 
> mesos-master start/running, process 2359
> + RETCODE=0
> + restore_netrc
> + mv /home/vagrant/.netrc.bak /home/vagrant/.netrc
> + true
> Connection to 127.0.0.1 closed.
> 
> real	28m58.389s
> user	0m1.508s
> sys	0m0.820s
> ```
> 
> 
> Thanks,
> 
> Mehrdad Nurolahzade
> 
>


--===============6160674978237853941==--