Return-Path: X-Original-To: archive-asf-public-internal@cust-asf2.ponee.io Delivered-To: archive-asf-public-internal@cust-asf2.ponee.io Received: from cust-asf.ponee.io (cust-asf.ponee.io [163.172.22.183]) by cust-asf2.ponee.io (Postfix) with ESMTP id 33235200C15 for ; Wed, 25 Jan 2017 02:08:13 +0100 (CET) Received: by cust-asf.ponee.io (Postfix) id 31D55160B4B; Wed, 25 Jan 2017 01:08:13 +0000 (UTC) Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by cust-asf.ponee.io (Postfix) with SMTP id A1054160B3E for ; Wed, 25 Jan 2017 02:08:12 +0100 (CET) Received: (qmail 30781 invoked by uid 500); 25 Jan 2017 01:08:11 -0000 Mailing-List: contact reviews-help@aurora.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: reviews@aurora.apache.org Delivered-To: mailing list reviews@aurora.apache.org Received: (qmail 30758 invoked by uid 99); 25 Jan 2017 01:08:11 -0000 Received: from reviews-vm.apache.org (HELO reviews.apache.org) (140.211.11.40) by apache.org (qpsmtpd/0.29) with ESMTP; Wed, 25 Jan 2017 01:08:11 +0000 Received: from reviews.apache.org (localhost [127.0.0.1]) by reviews.apache.org (Postfix) with ESMTP id 3224C3172A4; Wed, 25 Jan 2017 01:08:10 +0000 (UTC) Content-Type: multipart/alternative; boundary="===============4499623401581449569==" MIME-Version: 1.0 Subject: Review Request 55902: Capture health check output From: Dmitriy Shirchenko To: Joshua Cohen , Zameer Manji Cc: Dmitriy Shirchenko , Aurora Date: Wed, 25 Jan 2017 01:08:10 -0000 Message-ID: <20170125010810.13408.3879@reviews.apache.org> X-ReviewBoard-URL: https://reviews.apache.org/ Auto-Submitted: auto-generated Sender: Dmitriy Shirchenko X-ReviewGroup: Aurora X-Auto-Response-Suppress: DR, RN, OOF, AutoReply X-ReviewRequest-URL: https://reviews.apache.org/r/55902/ X-Sender: Dmitriy Shirchenko Reply-To: Dmitriy Shirchenko X-ReviewRequest-Repository: aurora archived-at: Wed, 25 Jan 2017 01:08:13 -0000 --===============4499623401581449569== MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/55902/ ----------------------------------------------------------- Review request for Aurora, Joshua Cohen and Zameer Manji. Bugs: AURORA-1881 https://issues.apache.org/jira/browse/AURORA-1881 Repository: aurora Description ------- Users really could really benefit from seeing the output of the shell health check failure, so plumbing through the output. Diffs ----- src/main/python/apache/aurora/common/health_check/shell.py 58470a48a7a14092eeb8837aada9e358c6922c93 src/test/python/apache/aurora/common/health_check/test_shell.py 792ef40028cda112db5b93c4cc37e305937bc351 Diff: https://reviews.apache.org/r/55902/diff/ Testing ------- added unit tests e2e tests screenshot attached. File Attachments ---------------- Screenshot https://reviews.apache.org/media/uploaded/files/2017/01/25/c4e69424-71ad-4d71-b1f4-895bc6a7821e__Screen_Shot_2017-01-24_at_5.03.06_PM.png Thanks, Dmitriy Shirchenko --===============4499623401581449569==--