Return-Path: X-Original-To: archive-asf-public-internal@cust-asf2.ponee.io Delivered-To: archive-asf-public-internal@cust-asf2.ponee.io Received: from cust-asf.ponee.io (cust-asf.ponee.io [163.172.22.183]) by cust-asf2.ponee.io (Postfix) with ESMTP id 064D1200C05 for ; Mon, 23 Jan 2017 21:44:58 +0100 (CET) Received: by cust-asf.ponee.io (Postfix) id 04E83160B49; Mon, 23 Jan 2017 20:44:58 +0000 (UTC) Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by cust-asf.ponee.io (Postfix) with SMTP id 4BE8F160B3C for ; Mon, 23 Jan 2017 21:44:57 +0100 (CET) Received: (qmail 61937 invoked by uid 500); 23 Jan 2017 20:44:56 -0000 Mailing-List: contact reviews-help@aurora.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: reviews@aurora.apache.org Delivered-To: mailing list reviews@aurora.apache.org Received: (qmail 61904 invoked by uid 99); 23 Jan 2017 20:44:56 -0000 Received: from reviews-vm.apache.org (HELO reviews.apache.org) (140.211.11.40) by apache.org (qpsmtpd/0.29) with ESMTP; Mon, 23 Jan 2017 20:44:56 +0000 Received: from reviews.apache.org (localhost [127.0.0.1]) by reviews.apache.org (Postfix) with ESMTP id C4E49316D02; Mon, 23 Jan 2017 20:44:54 +0000 (UTC) Content-Type: multipart/alternative; boundary="===============2184743928057567842==" MIME-Version: 1.0 Subject: Re: Review Request 54288: Make leader elections resilient to ZK disconnections. From: John Sirois To: Joshua Cohen , David McLaughlin , John Sirois , Stephan Erb Cc: Aurora , Zameer Manji Date: Mon, 23 Jan 2017 20:44:54 -0000 Message-ID: <20170123204454.13408.86170@reviews.apache.org> X-ReviewBoard-URL: https://reviews.apache.org/ Auto-Submitted: auto-generated Sender: John Sirois X-ReviewGroup: Aurora X-Auto-Response-Suppress: DR, RN, OOF, AutoReply X-ReviewRequest-URL: https://reviews.apache.org/r/54288/ X-Sender: John Sirois References: <20170123202142.13408.23464@reviews.apache.org> In-Reply-To: <20170123202142.13408.23464@reviews.apache.org> Reply-To: John Sirois X-ReviewRequest-Repository: aurora archived-at: Mon, 23 Jan 2017 20:44:58 -0000 --===============2184743928057567842== MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/54288/#review162691 ----------------------------------------------------------- @ReviewBot retry - John Sirois On Jan. 23, 2017, 1:21 p.m., Zameer Manji wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/54288/ > ----------------------------------------------------------- > > (Updated Jan. 23, 2017, 1:21 p.m.) > > > Review request for Aurora, David McLaughlin, Joshua Cohen, John Sirois, and Stephan Erb. > > > Bugs: AURORA-1669 > https://issues.apache.org/jira/browse/AURORA-1669 > > > Repository: aurora > > > Description > ------- > > As documented in AURORA-1840 the Curator `LeaderLatch` recipe abdicates > leadership if the ZK connection is lost or if there is a timeout. This is not > compatible with the commons based implementation which would only abdicate > leadership if the ZK session timeout occurred. > > This replaces the `LeaderLatch` recipe with the `LeaderSelector` recipe with a > custom listener that only loses leadership if a connection loss occurs. > > > Diffs > ----- > > commons/src/main/java/org/apache/aurora/common/zookeeper/testing/ZooKeeperTestServer.java 50acaeba82e163f8f2970a264cbd889c9eb3b5ed > src/main/java/org/apache/aurora/scheduler/discovery/CuratorSingletonService.java c378172c850aafe0a9381552b5067277b40dbfab > src/test/java/org/apache/aurora/scheduler/discovery/BaseCuratorDiscoveryTest.java a2b4125369d1f6c0a79bc4ac0fb3d2dab8a6c583 > src/test/java/org/apache/aurora/scheduler/discovery/CuratorSingletonServiceTest.java 6ea49b0c690d288ff59d1d4798144bfa2d153d3a > > Diff: https://reviews.apache.org/r/54288/diff/ > > > Testing > ------- > > > Thanks, > > Zameer Manji > > --===============2184743928057567842==--