Return-Path: X-Original-To: archive-asf-public-internal@cust-asf2.ponee.io Delivered-To: archive-asf-public-internal@cust-asf2.ponee.io Received: from cust-asf.ponee.io (cust-asf.ponee.io [163.172.22.183]) by cust-asf2.ponee.io (Postfix) with ESMTP id 51B2D200BFF for ; Tue, 17 Jan 2017 22:30:24 +0100 (CET) Received: by cust-asf.ponee.io (Postfix) id 510C5160B46; Tue, 17 Jan 2017 21:30:24 +0000 (UTC) Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by cust-asf.ponee.io (Postfix) with SMTP id 9B0E5160B30 for ; Tue, 17 Jan 2017 22:30:23 +0100 (CET) Received: (qmail 25620 invoked by uid 500); 17 Jan 2017 21:30:22 -0000 Mailing-List: contact reviews-help@aurora.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: reviews@aurora.apache.org Delivered-To: mailing list reviews@aurora.apache.org Received: (qmail 25594 invoked by uid 99); 17 Jan 2017 21:30:22 -0000 Received: from reviews-vm.apache.org (HELO reviews.apache.org) (140.211.11.40) by apache.org (qpsmtpd/0.29) with ESMTP; Tue, 17 Jan 2017 21:30:22 +0000 Received: from reviews.apache.org (localhost [127.0.0.1]) by reviews.apache.org (Postfix) with ESMTP id ECFA33150DB; Tue, 17 Jan 2017 21:30:21 +0000 (UTC) Content-Type: multipart/alternative; boundary="===============9207802979555885169==" MIME-Version: 1.0 Subject: Review Request 55646: Ensure Aurora thrift support js and html. From: John Sirois To: Joshua Cohen Cc: Aurora , John Sirois Date: Tue, 17 Jan 2017 21:30:21 -0000 Message-ID: <20170117213021.28414.63717@reviews.apache.org> X-ReviewBoard-URL: https://reviews.apache.org/ Auto-Submitted: auto-generated Sender: John Sirois X-ReviewGroup: Aurora X-Auto-Response-Suppress: DR, RN, OOF, AutoReply X-ReviewRequest-URL: https://reviews.apache.org/r/55646/ X-Sender: John Sirois Reply-To: John Sirois X-ReviewRequest-Repository: aurora archived-at: Tue, 17 Jan 2017 21:30:24 -0000 --===============9207802979555885169== MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/55646/ ----------------------------------------------------------- Review request for Aurora and Joshua Cohen. Bugs: AURORA-1875 https://issues.apache.org/jira/browse/AURORA-1875 Repository: aurora Description ------- We use these for the Aurora UI and the API docs. build-support/thrift/thriftw | 2 ++ 1 file changed, 2 insertions(+) Diffs ----- build-support/thrift/thriftw 278576f22b6127da306e2b12ece3686981a317d3 Diff: https://reviews.apache.org/r/55646/diff/ Testing ------- Missed these 2 in https://reviews.apache.org/r/55536/ Our custom thrift build does not rebuild since it passes the new checks: ``` $ ./build-support/thrift/thriftw 0.9.1 --which /home/jsirois/dev/apache/jsirois-aurora/build-support/thrift/thrift-0.9.1/compiler/cpp/thrift $ ./build-support/thrift/thriftw 0.9.1 -help 2>&1 | grep -iE "javascript|html" html (HTML): standalone: Self-contained mode, includes all CSS in the HTML files. Generates no style.css file, but HTML files will be larger. js (Javascript): ``` Thanks, John Sirois --===============9207802979555885169==--