aurora-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Zameer Manji <zma...@apache.org>
Subject Re: Review Request 56131: Suppress role deprecation warning as replacement is not yet ready.
Date Tue, 31 Jan 2017 19:09:45 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/56131/#review163697
-----------------------------------------------------------


Ship it!




Ship It!


src/main/java/org/apache/aurora/scheduler/mesos/CommandLineDriverSettingsModule.java (line
155)
<https://reviews.apache.org/r/56131/#comment235171>

    Can you link to the commit that did this or something? It would make it much easier to
determine later if we can remove it.


- Zameer Manji


On Jan. 31, 2017, 10:41 a.m., David McLaughlin wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/56131/
> -----------------------------------------------------------
> 
> (Updated Jan. 31, 2017, 10:41 a.m.)
> 
> 
> Review request for Aurora, Mehrdad Nurolahzade, Santhosh Kumar Shanmugham, and Stephan
Erb.
> 
> 
> Repository: aurora
> 
> 
> Description
> -------
> 
> The role field was prematurely deprecated in the Mesos project. https://github.com/apache/mesos/blob/master/include/mesos/mesos.proto#L257
> 
> Suppress deprecation warnings.
> 
> 
> Diffs
> -----
> 
>   src/main/java/org/apache/aurora/scheduler/mesos/CommandLineDriverSettingsModule.java
49877682e501d0af76f6e2583b59e93b1bd90137 
> 
> Diff: https://reviews.apache.org/r/56131/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> David McLaughlin
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message