aurora-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Joshua Cohen <jco...@apache.org>
Subject Re: Review Request 55951: Use --launch_info when invoking MesosContainerizer.
Date Wed, 25 Jan 2017 19:21:39 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/55951/#review163003
-----------------------------------------------------------




build-support/packer/build.sh (line 20)
<https://reviews.apache.org/r/55951/#comment234383>

    This should probably be reverted?



src/main/python/apache/thermos/common/process_util.py (lines 25 - 37)
<https://reviews.apache.org/r/55951/#comment234384>

    Rather than continuing to manually construct a json representation of a protobuf, we might
want to look at just creating the actual `LaunchInfo` protobuf and converting it directly
to json?
    
    I looked into this at one point, and it was problematic due to the version of the protobuf
library we use (tied to the version in use by Mesos). I remember thinking the problem wasn't
intractable though. Would you mind taking a swing at that now that the json object is more
complex?


- Joshua Cohen


On Jan. 25, 2017, 7:02 p.m., Santhosh Kumar Shanmugham wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/55951/
> -----------------------------------------------------------
> 
> (Updated Jan. 25, 2017, 7:02 p.m.)
> 
> 
> Review request for Aurora, Joshua Cohen, Stephan Erb, and Karthik Anantha Padmanabhan.
> 
> 
> Bugs: AURORA-1882
>     https://issues.apache.org/jira/browse/AURORA-1882
> 
> 
> Repository: aurora
> 
> 
> Description
> -------
> 
> MesosContainerizer has updated the command line parameters and
> consolidated the individual arguments into a single ContainerLaunchInfo
> proto buf message. Update ThermosExecutor to use the new `--launch_info`
> parameter to be compatible with MesosContainerizer.
> 
> 
> Diffs
> -----
> 
>   build-support/packer/build.sh 548cf37e097c6ed56fc6cc718a642b105afb9331 
>   src/main/python/apache/thermos/common/process_util.py 54e716b726fc02f3901f1b9143d3fa253511e29b

>   src/test/python/apache/thermos/core/test_process.py 520390217f691b9136cb4d36262be3d372a16509

> 
> Diff: https://reviews.apache.org/r/55951/diff/
> 
> 
> Testing
> -------
> 
> build-support/jenkins/build.sh
> 
> TBD: End-to-end test needs Mesos 1.2.0 which has not been released?
> 
> 
> Thanks,
> 
> Santhosh Kumar Shanmugham
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message