aurora-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Dmitriy Shirchenko <cald...@gmail.com>
Subject Re: Review Request 55902: Capture health check output
Date Wed, 25 Jan 2017 18:37:43 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/55902/
-----------------------------------------------------------

(Updated Jan. 25, 2017, 6:37 p.m.)


Review request for Aurora, Joshua Cohen and Zameer Manji.


Bugs: AURORA-1881
    https://issues.apache.org/jira/browse/AURORA-1881


Repository: aurora


Description
-------

Users really could really benefit from seeing the output of the shell health check failure,
so plumbing through the output.


Diffs (updated)
-----

  src/main/python/apache/aurora/common/health_check/shell.py 58470a48a7a14092eeb8837aada9e358c6922c93

  src/test/python/apache/aurora/common/health_check/test_shell.py 792ef40028cda112db5b93c4cc37e305937bc351


Diff: https://reviews.apache.org/r/55902/diff/


Testing
-------

added unit tests
e2e tests
screenshot attached.


File Attachments
----------------

Updated screenshot
  https://reviews.apache.org/media/uploaded/files/2017/01/25/90d6ff4f-84f9-4b4d-9b3d-56dadf7027ae__Screen_Shot_2017-01-24_at_5.32.08_PM.png


Thanks,

Dmitriy Shirchenko


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message