aurora-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Aurora ReviewBot <wfar...@apache.org>
Subject Re: Review Request 55902: Capture health check output
Date Wed, 25 Jan 2017 01:45:51 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/55902/#review162896
-----------------------------------------------------------



Master (52ddce9) is red with this patch.
  ./build-support/jenkins/build.sh

virtualenv-15.0.2/virtualenv_support/wheel-0.29.0-py2.py3-none-any.whl
+ touch virtualenv-15.0.2/BOOTSTRAPPED
+ popd
/home/jenkins/jenkins-slave/workspace/AuroraBot
+ exec /usr/bin/python2.7 /home/jenkins/jenkins-slave/workspace/AuroraBot/build-support/virtualenv-15.0.2/virtualenv.py
--no-download /home/jenkins/jenkins-slave/workspace/AuroraBot/build-support/python/isort.venv
New python executable in /home/jenkins/jenkins-slave/workspace/AuroraBot/build-support/python/isort.venv/bin/python2.7
Also creating executable in /home/jenkins/jenkins-slave/workspace/AuroraBot/build-support/python/isort.venv/bin/python
Installing setuptools, pip, wheel...done.
Collecting isort==4.0.0
  Downloading isort-4.0.0-py2.py3-none-any.whl
Installing collected packages: isort
Successfully installed isort-4.0.0
You are using pip version 8.1.2, however version 9.0.1 is available.
You should consider upgrading via the 'pip install --upgrade pip' command.
ERROR: /home/jenkins/jenkins-slave/workspace/AuroraBot/src/main/python/apache/aurora/common/health_check/shell.py
Imports are incorrectly sorted.
--- /home/jenkins/jenkins-slave/workspace/AuroraBot/src/main/python/apache/aurora/common/health_check/shell.py:before
2017-01-25 01:41:27.669006
+++ /home/jenkins/jenkins-slave/workspace/AuroraBot/src/main/python/apache/aurora/common/health_check/shell.py:after
2017-01-25 01:45:51.877003
@@ -16,6 +16,7 @@
 import sys
 
 from subprocess32 import STDOUT
+
 # Recommended pattern for Python 2 and 3 support from https://github.com/google/python-subprocess32
 # Backport which adds bug fixes and timeout support for Python 2.7
 if os.name == 'posix' and sys.version_info[0] < 3:
ERROR: /home/jenkins/jenkins-slave/workspace/AuroraBot/src/test/python/apache/aurora/common/health_check/test_shell.py
Imports are incorrectly sorted.
--- /home/jenkins/jenkins-slave/workspace/AuroraBot/src/test/python/apache/aurora/common/health_check/test_shell.py:before
2017-01-25 01:41:27.669006
+++ /home/jenkins/jenkins-slave/workspace/AuroraBot/src/test/python/apache/aurora/common/health_check/test_shell.py:after
2017-01-25 01:45:52.368200
@@ -17,10 +17,10 @@
 import unittest
 
 import mock
+from subprocess32 import STDOUT
 
 from apache.aurora.common.health_check.shell import ShellHealthCheck
 
-from subprocess32 import STDOUT
 # Recommended pattern for Python 2 and 3 support from https://github.com/google/python-subprocess32
 # Backport which adds bug fixes and timeout support for Python 2.7
 if os.name == 'posix' and sys.version_info[0] < 3:


I will refresh this build result if you post a review containing "@ReviewBot retry"

- Aurora ReviewBot


On Jan. 25, 2017, 1:34 a.m., Dmitriy Shirchenko wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/55902/
> -----------------------------------------------------------
> 
> (Updated Jan. 25, 2017, 1:34 a.m.)
> 
> 
> Review request for Aurora, Joshua Cohen and Zameer Manji.
> 
> 
> Bugs: AURORA-1881
>     https://issues.apache.org/jira/browse/AURORA-1881
> 
> 
> Repository: aurora
> 
> 
> Description
> -------
> 
> Users really could really benefit from seeing the output of the shell health check failure,
so plumbing through the output.
> 
> 
> Diffs
> -----
> 
>   src/main/python/apache/aurora/common/health_check/shell.py 58470a48a7a14092eeb8837aada9e358c6922c93

>   src/test/python/apache/aurora/common/health_check/test_shell.py 792ef40028cda112db5b93c4cc37e305937bc351

> 
> Diff: https://reviews.apache.org/r/55902/diff/
> 
> 
> Testing
> -------
> 
> added unit tests
> e2e tests
> screenshot attached.
> 
> 
> File Attachments
> ----------------
> 
> Updated screenshot
>   https://reviews.apache.org/media/uploaded/files/2017/01/25/90d6ff4f-84f9-4b4d-9b3d-56dadf7027ae__Screen_Shot_2017-01-24_at_5.32.08_PM.png
> 
> 
> Thanks,
> 
> Dmitriy Shirchenko
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message