aurora-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Mehrdad Nurolahzade <mehr...@nurolahzade.com>
Subject Re: Review Request 55471: AURORA-1876 Expose stats on scheduler rate limiter
Date Mon, 23 Jan 2017 17:00:24 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/55471/
-----------------------------------------------------------

(Updated Jan. 23, 2017, 9 a.m.)


Review request for Aurora, Joshua Cohen and Stephan Erb.


Changes
-------

Changed stat from time tracker to counter (as per comments above)


Summary (updated)
-----------------

AURORA-1876 Expose stats on scheduler rate limiter


Bugs: AURORA-1876
    https://issues.apache.org/jira/browse/AURORA-1876


Repository: aurora


Description (updated)
-------

This patch exposes stats on `rateLimiter.acquire()` blocking events in `TaskGroups`. Hence,
providing visibility into whether scheduling rate is above/below `MAX_SCHEDULE_ATTEMPTS_PER_SEC`.


Diffs (updated)
-----

  src/main/java/org/apache/aurora/scheduler/scheduling/TaskGroups.java 2d548b0adc9219080aa8e0e8b329f57edda01c13

  src/test/java/org/apache/aurora/scheduler/scheduling/TaskGroupsTest.java 566e0d9ee8976a5eadd3088d34280fcfb0de3df0


Diff: https://reviews.apache.org/r/55471/diff/


Testing (updated)
-------

```
$ curl localhost:8081/vars | grep schedule_attempts_blocks
  % Total    % Received % Xferd  Average Speed   Time    Time     Time  Current
                                 Dload  Upload   Total   Spent    Left  Speed
100 27976    0 27976    0     0  2836k      0 --:--:-- --:--:-- --:--:-- 3415k
schedule_attempts_blocks 0
```


Thanks,

Mehrdad Nurolahzade


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message