aurora-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Joshua Cohen <jco...@apache.org>
Subject Re: Review Request 55684: Fix command escaping when using the Mesos containerizer
Date Thu, 19 Jan 2017 19:41:52 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/55684/#review162338
-----------------------------------------------------------


Ship it!




Ship It!

- Joshua Cohen


On Jan. 18, 2017, 8:54 p.m., Stephan Erb wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/55684/
> -----------------------------------------------------------
> 
> (Updated Jan. 18, 2017, 8:54 p.m.)
> 
> 
> Review request for Aurora, Joshua Cohen and Zameer Manji.
> 
> 
> Bugs: AURORA-1782
>     https://issues.apache.org/jira/browse/AURORA-1782
> 
> 
> Repository: aurora
> 
> 
> Description
> -------
> 
> The important bit is the change to call the Mesos containerizer with `shell=False`. Getting
rid of manual json encoding and eliminating shlex might have helped as well, but was more
motivated by clarity rather than correctness.
> 
> 
> Diffs
> -----
> 
>   src/main/python/apache/aurora/common/health_check/shell.py 6ac9021c3ef3324c64f23f068b31b0c239a0349e

>   src/main/python/apache/aurora/executor/common/health_checker.py a5fb18f367c8ad1321267a8f75e3b9aca0ad1ff5

>   src/main/python/apache/thermos/common/process_util.py 637b025dd98348b2741aa1c03117e1bc899022d5

>   src/main/python/apache/thermos/core/process.py 496b5401b0656115750513cf038104fbc1b3c654

>   src/test/python/apache/aurora/common/health_check/test_shell.py 4f028787d7ec5fa73263718d8bddff4c8ccdd477

>   src/test/python/apache/aurora/executor/common/test_health_checker.py 86a71c7be44ef442fa839a9677300155386550b9

>   src/test/python/apache/thermos/core/test_process.py 2fd3d9618cddefdd7863a3a88e294d5e79562b2e

>   src/test/sh/org/apache/aurora/e2e/http/http_example.aurora 1985f89ffc9142877bc168c93a7efd19b6bcd4aa

> 
> Diff: https://reviews.apache.org/r/55684/diff/
> 
> 
> Testing
> -------
> 
> I have verifed that the new e2e fail with the code on master but succeed with this patch.
> 
> ./src/test/sh/org/apache/aurora/e2e/test_end_to_end.sh
> 
> 
> Thanks,
> 
> Stephan Erb
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message