aurora-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Aurora ReviewBot <wfar...@apache.org>
Subject Re: Review Request 55646: Ensure Aurora thrift support js and html.
Date Tue, 17 Jan 2017 22:33:14 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/55646/#review161977
-----------------------------------------------------------


Ship it!




Master (4e92be4) is green with this patch.
  ./build-support/jenkins/build.sh

I will refresh this build result if you post a review containing "@ReviewBot retry"

- Aurora ReviewBot


On Jan. 17, 2017, 9:30 p.m., John Sirois wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/55646/
> -----------------------------------------------------------
> 
> (Updated Jan. 17, 2017, 9:30 p.m.)
> 
> 
> Review request for Aurora and Joshua Cohen.
> 
> 
> Bugs: AURORA-1875
>     https://issues.apache.org/jira/browse/AURORA-1875
> 
> 
> Repository: aurora
> 
> 
> Description
> -------
> 
> We use these for the Aurora UI and the API docs.
> 
>  build-support/thrift/thriftw | 2 ++
>  1 file changed, 2 insertions(+)
> 
> 
> Diffs
> -----
> 
>   build-support/thrift/thriftw 278576f22b6127da306e2b12ece3686981a317d3 
> 
> Diff: https://reviews.apache.org/r/55646/diff/
> 
> 
> Testing
> -------
> 
> Missed these 2 in https://reviews.apache.org/r/55536/
> 
> Our custom thrift build does not rebuild since it passes the new checks:
> ```
> $ ./build-support/thrift/thriftw 0.9.1 --which
> /home/jsirois/dev/apache/jsirois-aurora/build-support/thrift/thrift-0.9.1/compiler/cpp/thrift
> $ ./build-support/thrift/thriftw 0.9.1 -help 2>&1 | grep -iE "javascript|html"
>   html (HTML):
>     standalone:      Self-contained mode, includes all CSS in the HTML files.
>                      Generates no style.css file, but HTML files will be larger.
>   js (Javascript):
> ```
> 
> 
> Thanks,
> 
> John Sirois
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message