aurora-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Aurora ReviewBot <wfar...@apache.org>
Subject Re: Review Request 55583: Make announced scheduler endpoint name configurable
Date Mon, 16 Jan 2017 22:43:27 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/55583/#review161797
-----------------------------------------------------------



Master (b75dfb8) is green with this patch.
  ./build-support/jenkins/build.sh

However, it appears that it might lack test coverage.

I will refresh this build result if you post a review containing "@ReviewBot retry"

- Aurora ReviewBot


On Jan. 16, 2017, 10:27 p.m., Stephan Erb wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/55583/
> -----------------------------------------------------------
> 
> (Updated Jan. 16, 2017, 10:27 p.m.)
> 
> 
> Review request for Aurora, John Sirois and Zameer Manji.
> 
> 
> Bugs: AURORA-343
>     https://issues.apache.org/jira/browse/AURORA-343
> 
> 
> Repository: aurora
> 
> 
> Description
> -------
> 
> We decided to co-deploy an HTTPS enabled reverse proxy in front of each of our Aurora
schedulers. The proxy instances bind to `public_ip:8081` and the schedulers to `localhost:8081`.
By announcing the scheduler endpoint as `https` we can ensure the default Aurora [client connects
via HTTPS](https://github.com/apache/aurora/blob/master/src/main/python/apache/aurora/client/api/scheduler_client.py#L176-L178).
> 
> 
> Diffs
> -----
> 
>   RELEASE-NOTES.md 164d7a36b745ec3150967c5d34893f6076579115 
>   docs/operations/security.md 46e0b8a9db654f52467f9adf36307a6a97a7a3ec 
>   docs/reference/scheduler-configuration.md d4e0a9a4735c17d2af9b5f3381beea03ccf84d75

>   src/main/java/org/apache/aurora/scheduler/app/SchedulerMain.java 43cc5b4645bc26b0fc6b23726ad3292699048ded

> 
> Diff: https://reviews.apache.org/r/55583/diff/
> 
> 
> Testing
> -------
> 
> Default:
> 
>     [zk: 127.0.0.1:2181(CONNECTED) 5] get /aurora/scheduler/member_0000000011
>     {"serviceEndpoint":{"host":"aurora.local","port":8081},"additionalEndpoints":{"http":{"host":"aurora.local","port":8081}},"status":"ALIVE"}
>     
> When running with `-serverset_endpoint_name=https`:
> 
>     [zk: 127.0.0.1:2181(CONNECTED) 0] get /aurora/scheduler/member_0000000019
>     {"serviceEndpoint":{"host":"aurora.local","port":8081},"additionalEndpoints":{"https":{"host":"aurora.local","port":8081}},"status":"ALIVE"}
> 
> 
> Thanks,
> 
> Stephan Erb
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message