aurora-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Mehrdad Nurolahzade <mehr...@nurolahzade.com>
Subject Re: Review Request 55471: AURORA-1876 Expose stats on scheduler rate limiter blocking time
Date Fri, 13 Jan 2017 20:00:53 GMT


> On Jan. 13, 2017, 11:47 a.m., Mehrdad Nurolahzade wrote:
> > Thinking about it, maybe we should expose this metric as a counter rather than time.
Thoughts?
> 
> Zameer Manji wrote:
>     What would it be counting exactly?

Number of times sleep time has been > 0; with time it is not possible to say how many events
have been aggregated.


- Mehrdad


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/55471/#review161577
-----------------------------------------------------------


On Jan. 12, 2017, 2:46 p.m., Mehrdad Nurolahzade wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/55471/
> -----------------------------------------------------------
> 
> (Updated Jan. 12, 2017, 2:46 p.m.)
> 
> 
> Review request for Aurora, Joshua Cohen and Stephan Erb.
> 
> 
> Bugs: AURORA-1876
>     https://issues.apache.org/jira/browse/AURORA-1876
> 
> 
> Repository: aurora
> 
> 
> Description
> -------
> 
> This patch exposes stats on `rateLimiter.acquire()` sleep time in `TaskGroups`. Hence,
providing visibility into whether scheduling rate is above/below `MAX_SCHEDULE_ATTEMPTS_PER_SEC`.
> 
> 
> Diffs
> -----
> 
>   src/main/java/org/apache/aurora/scheduler/scheduling/TaskGroups.java 2d548b0adc9219080aa8e0e8b329f57edda01c13

>   src/test/java/org/apache/aurora/scheduler/scheduling/TaskGroupsTest.java 566e0d9ee8976a5eadd3088d34280fcfb0de3df0

> 
> Diff: https://reviews.apache.org/r/55471/diff/
> 
> 
> Testing
> -------
> 
> ```
> $ curl localhost:8081/vars | grep schedule_attempts_sleep_time_nanos
>   % Total    % Received % Xferd  Average Speed   Time    Time     Time  Current
>                                  Dload  Upload   Total   Spent    Left  Speed
> 100 44008    0 44008    0     0  5236k      0 --:--:-- --:--:-- --:--:-- 5372k
> schedule_attempts_sleep_time_nanos 0
> ```
> 
> 
> Thanks,
> 
> Mehrdad Nurolahzade
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message