aurora-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Aurora ReviewBot <wfar...@apache.org>
Subject Re: Review Request 55471: AURORA-1876 Expose stats on scheduler rate limiter blocking time
Date Thu, 12 Jan 2017 22:52:03 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/55471/#review161444
-----------------------------------------------------------



Master (06a221f) is red with this patch.
  ./build-support/jenkins/build.sh

thrift-0.9.1/tutorial/py/Makefile.am
thrift-0.9.1/tutorial/py/Makefile.in
thrift-0.9.1/tutorial/py/PythonClient.py
thrift-0.9.1/tutorial/py/PythonServer.py
thrift-0.9.1/tutorial/py.tornado/
thrift-0.9.1/tutorial/py.tornado/Makefile.am
thrift-0.9.1/tutorial/py.tornado/Makefile.in
thrift-0.9.1/tutorial/py.tornado/PythonClient.py
thrift-0.9.1/tutorial/py.tornado/PythonServer.py
thrift-0.9.1/tutorial/py.twisted/
thrift-0.9.1/tutorial/py.twisted/Makefile.am
thrift-0.9.1/tutorial/py.twisted/Makefile.in
thrift-0.9.1/tutorial/py.twisted/PythonClient.py
thrift-0.9.1/tutorial/py.twisted/PythonServer.py
thrift-0.9.1/tutorial/py.twisted/PythonServer.tac
thrift-0.9.1/tutorial/rb/
thrift-0.9.1/tutorial/rb/Makefile.am
thrift-0.9.1/tutorial/rb/Makefile.in
thrift-0.9.1/tutorial/rb/RubyClient.rb
thrift-0.9.1/tutorial/rb/RubyServer.rb
thrift-0.9.1/tutorial/README
thrift-0.9.1/tutorial/shared.thrift
thrift-0.9.1/tutorial/tutorial.thrift
thrift-0.9.1/ylwrap
make: *** [thrift-0.9.1/compiler/cpp/thrift] Error 1
make: Leaving directory `/home/jenkins/jenkins-slave/workspace/AuroraBot/build-support/thrift'
:api:generateThriftJava FAILED

FAILURE: Build failed with an exception.

* What went wrong:
Execution failed for task ':api:generateThriftJava'.
> Process 'command '/home/jenkins/jenkins-slave/workspace/AuroraBot/build-support/thrift/thriftw''
finished with non-zero exit value 2

* Try:
Run with --stacktrace option to get the stack trace. Run with --info or --debug option to
get more log output.

BUILD FAILED

Total time: 12.62 secs


I will refresh this build result if you post a review containing "@ReviewBot retry"

- Aurora ReviewBot


On Jan. 12, 2017, 10:46 p.m., Mehrdad Nurolahzade wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/55471/
> -----------------------------------------------------------
> 
> (Updated Jan. 12, 2017, 10:46 p.m.)
> 
> 
> Review request for Aurora, Joshua Cohen and Stephan Erb.
> 
> 
> Bugs: AURORA-1876
>     https://issues.apache.org/jira/browse/AURORA-1876
> 
> 
> Repository: aurora
> 
> 
> Description
> -------
> 
> This patch exposes stats on `rateLimiter.acquire()` sleep time in `TaskGroups`. Hence,
providing visibility into whether scheduling rate is above/below `MAX_SCHEDULE_ATTEMPTS_PER_SEC`.
> 
> 
> Diffs
> -----
> 
>   src/main/java/org/apache/aurora/scheduler/scheduling/TaskGroups.java 2d548b0adc9219080aa8e0e8b329f57edda01c13

>   src/test/java/org/apache/aurora/scheduler/scheduling/TaskGroupsTest.java 566e0d9ee8976a5eadd3088d34280fcfb0de3df0

> 
> Diff: https://reviews.apache.org/r/55471/diff/
> 
> 
> Testing
> -------
> 
> ```
> $ curl localhost:8081/vars | grep schedule_attempts_sleep_time_nanos
>   % Total    % Received % Xferd  Average Speed   Time    Time     Time  Current
>                                  Dload  Upload   Total   Spent    Left  Speed
> 100 44008    0 44008    0     0  5236k      0 --:--:-- --:--:-- --:--:-- 5372k
> schedule_attempts_sleep_time_nanos 0
> ```
> 
> 
> Thanks,
> 
> Mehrdad Nurolahzade
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message