aurora-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Joshua Cohen <jco...@apache.org>
Subject Re: Review Request 55434: Reduce logging by ChainedStatusChecker and StatusManager when they're on the happy path.
Date Wed, 11 Jan 2017 22:19:10 GMT


> On Jan. 11, 2017, 10:05 p.m., Stephan Erb wrote:
> > src/main/python/apache/aurora/executor/common/status_checker.py, line 134
> > <https://reviews.apache.org/r/55434/diff/1/?file=1603106#file1603106line134>
> >
> >     Just like Java, Python can do the formatting for you when needed. Just pass
your arguments directly to the info function and the logger will do the rest if needed.

done, thanks for the nudge.


- Joshua


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/55434/#review161310
-----------------------------------------------------------


On Jan. 11, 2017, 10:18 p.m., Joshua Cohen wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/55434/
> -----------------------------------------------------------
> 
> (Updated Jan. 11, 2017, 10:18 p.m.)
> 
> 
> Review request for Aurora and Santhosh Kumar Shanmugham.
> 
> 
> Bugs: AURORA-1878
>     https://issues.apache.org/jira/browse/AURORA-1878
> 
> 
> Repository: aurora
> 
> 
> Description
> -------
> 
> Reduce logging by ChainedStatusChecker and StatusManager when they're  on the happy path.
> 
> 
> Diffs
> -----
> 
>   src/main/python/apache/aurora/executor/common/status_checker.py f278825e58bba40c3b3ec735173705feb42bf165

>   src/main/python/apache/aurora/executor/status_manager.py 8b536a925e3f209c03b3eb44257096a0c0e497e0

> 
> Diff: https://reviews.apache.org/r/55434/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Joshua Cohen
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message