aurora-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Joshua Cohen <jco...@apache.org>
Subject Re: Review Request 55347: Ensure destination exists when mounting files into a filesystem image.
Date Tue, 10 Jan 2017 18:01:22 GMT


> On Jan. 9, 2017, 7:28 p.m., Stephan Erb wrote:
> > src/main/python/apache/aurora/executor/common/sandbox.py, lines 285-290
> > <https://reviews.apache.org/r/55347/diff/1/?file=1600157#file1600157line285>
> >
> >     This looks suspicious. Creating a directory and then checking it does not exist.

Fixed.


> On Jan. 9, 2017, 7:28 p.m., Stephan Erb wrote:
> > src/test/python/apache/aurora/executor/common/test_sandbox.py, lines 404-410
> > <https://reviews.apache.org/r/55347/diff/1/?file=1600158#file1600158line404>
> >
> >     With that amount of mocking the test is both hard to understand and brittle
to changes of the production code.
> >     
> >     Have you considered extending this https://github.com/apache/aurora/blob/master/examples/vagrant/upstart/aurora-scheduler.conf#L43
list instead?

Added to startup config and added e2e test as well.


- Joshua


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/55347/#review160933
-----------------------------------------------------------


On Jan. 10, 2017, 6 p.m., Joshua Cohen wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/55347/
> -----------------------------------------------------------
> 
> (Updated Jan. 10, 2017, 6 p.m.)
> 
> 
> Review request for Aurora, Santhosh Kumar Shanmugham and Stephan Erb.
> 
> 
> Repository: aurora
> 
> 
> Description
> -------
> 
> When testing filesystem isolation internally, we ran into an issue where mounting a regular
file into the task filesystem failed with exit code 32 since the mount destination did not
exist. To account for this, we'll touch an empty file in the taskfs.
> 
> 
> Diffs
> -----
> 
>   examples/vagrant/upstart/aurora-scheduler.conf e68a801017ae02e0ed581129e12a645ccc1e35d4

>   src/main/python/apache/aurora/executor/common/sandbox.py 9d6e73c4221302c56596ef3591bdeab41c81535e

>   src/test/python/apache/aurora/executor/common/test_sandbox.py a441d2a60e413395b74b62445846e3871784e729

>   src/test/sh/org/apache/aurora/e2e/http/http_example.aurora 438eb0f03128d21b3201d0a843adebe09422c75e

>   src/test/sh/org/apache/aurora/e2e/test_end_to_end.sh 46309371a33d26bdd467b5fa131634354be2a978

> 
> Diff: https://reviews.apache.org/r/55347/diff/
> 
> 
> Testing
> -------
> 
> ./build-support/jenkins/build.sh
> 
> 
> Thanks,
> 
> Joshua Cohen
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message