aurora-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Renan DelValle <rdelv...@binghamton.edu>
Subject Re: Review Request 52437: Adding support for Ubuntu Xenial packages
Date Wed, 04 Jan 2017 16:26:05 GMT


> On Jan. 4, 2017, 6:01 a.m., Stephan Erb wrote:
> > We used to have shared specs for all Debian-based distributions. This patch is now
duplicating `specs/debian` for `ubuntu-xenial`. Is there anything particular that makes this
necessary?

The reason why I have it a separate the specs  is two fold. First ubuntu xenial doesn’t
play well if there’s _any_ init script installed, so the separate spec doesn't have them
(we can achieve the same effect by only copying necessary files out of a common folder). Second,
the existing SystemD unit scripts for debian were not all that native. I wrote new ones to
be closer to their RPM counterparts. However, as the debian ones are already being used, I
didn't want to force my changes upon anyone. We can decide as a community the way we want
to handle this though.


- Renan


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/52437/#review160490
-----------------------------------------------------------


On Jan. 4, 2017, 5:43 a.m., Renan DelValle wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/52437/
> -----------------------------------------------------------
> 
> (Updated Jan. 4, 2017, 5:43 a.m.)
> 
> 
> Review request for Aurora, Dmitriy Shirchenko and Zameer Manji.
> 
> 
> Bugs: AURORA-1872
>     https://issues.apache.org/jira/browse/AURORA-1872
> 
> 
> Repository: aurora-packaging
> 
> 
> Description
> -------
> 
> Added builder and test environment for Xenial as well as updated instructions on how
to test it.
> 
> Added distributtion to release-candidate script.
> 
> 
> Diffs
> -----
> 
>   build-support/release/release-candidate 98df82412b6218ed7c1f650a7b1cc725ac297c37 
>   builder/deb/ubuntu-xenial/Dockerfile PRE-CREATION 
>   builder/deb/ubuntu-xenial/build.sh PRE-CREATION 
>   specs/debian/aurora-pants.ini e4f2c54df45f746ffb2a4e3f786fc4105323bc0b 
>   specs/debian/aurora-scheduler.startup.sh PRE-CREATION 
>   specs/ubuntu-xenial/aurora-doc.docs PRE-CREATION 
>   specs/ubuntu-xenial/aurora-doc.examples PRE-CREATION 
>   specs/ubuntu-xenial/aurora-pants.ini PRE-CREATION 
>   specs/ubuntu-xenial/aurora-scheduler.default PRE-CREATION 
>   specs/ubuntu-xenial/aurora-scheduler.install PRE-CREATION 
>   specs/ubuntu-xenial/aurora-scheduler.links PRE-CREATION 
>   specs/ubuntu-xenial/aurora-scheduler.postinst PRE-CREATION 
>   specs/ubuntu-xenial/aurora-scheduler.service PRE-CREATION 
>   specs/ubuntu-xenial/aurora-scheduler.startup.sh PRE-CREATION 
>   specs/ubuntu-xenial/aurora-tools.install PRE-CREATION 
>   specs/ubuntu-xenial/aurora-tools.links PRE-CREATION 
>   specs/ubuntu-xenial/changelog PRE-CREATION 
>   specs/ubuntu-xenial/clusters.json PRE-CREATION 
>   specs/ubuntu-xenial/compat PRE-CREATION 
>   specs/ubuntu-xenial/control PRE-CREATION 
>   specs/ubuntu-xenial/copyright PRE-CREATION 
>   specs/ubuntu-xenial/rules PRE-CREATION 
>   specs/ubuntu-xenial/source/format PRE-CREATION 
>   specs/ubuntu-xenial/thermos.default PRE-CREATION 
>   specs/ubuntu-xenial/thermos.dirs PRE-CREATION 
>   specs/ubuntu-xenial/thermos.install PRE-CREATION 
>   specs/ubuntu-xenial/thermos.links PRE-CREATION 
>   specs/ubuntu-xenial/thermos.service PRE-CREATION 
>   test/deb/ubuntu-xenial/README.md PRE-CREATION 
>   test/deb/ubuntu-xenial/Vagrantfile PRE-CREATION 
>   test/deb/ubuntu-xenial/provision.sh PRE-CREATION 
> 
> Diff: https://reviews.apache.org/r/52437/diff/
> 
> 
> Testing
> -------
> 
> Created artifacts using the build-artifacts script.
> 
> Brought a vagrant image up, installed all deb files created by the artifacts script,
started both aurora-scheduler and thermos services, and launched a sample job.
> 
> 
> Thanks,
> 
> Renan DelValle
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message