Return-Path: X-Original-To: archive-asf-public-internal@cust-asf2.ponee.io Delivered-To: archive-asf-public-internal@cust-asf2.ponee.io Received: from cust-asf.ponee.io (cust-asf.ponee.io [163.172.22.183]) by cust-asf2.ponee.io (Postfix) with ESMTP id E5BBC200BE8 for ; Fri, 23 Dec 2016 09:11:01 +0100 (CET) Received: by cust-asf.ponee.io (Postfix) id E4549160B1E; Fri, 23 Dec 2016 08:11:01 +0000 (UTC) Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by cust-asf.ponee.io (Postfix) with SMTP id 3B7A5160B1D for ; Fri, 23 Dec 2016 09:11:01 +0100 (CET) Received: (qmail 67565 invoked by uid 500); 23 Dec 2016 08:11:00 -0000 Mailing-List: contact reviews-help@aurora.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: reviews@aurora.apache.org Delivered-To: mailing list reviews@aurora.apache.org Received: (qmail 67503 invoked by uid 99); 23 Dec 2016 08:11:00 -0000 Received: from reviews-vm.apache.org (HELO reviews.apache.org) (140.211.11.40) by apache.org (qpsmtpd/0.29) with ESMTP; Fri, 23 Dec 2016 08:11:00 +0000 Received: from reviews.apache.org (localhost [127.0.0.1]) by reviews.apache.org (Postfix) with ESMTP id 843CE30F83F; Fri, 23 Dec 2016 08:10:59 +0000 (UTC) Content-Type: multipart/alternative; boundary="===============1645378972672328772==" MIME-Version: 1.0 Subject: Re: Review Request 55003: AURORA-1848 Expose ResponseCode stats on Thrift server calls From: David McLaughlin To: Joshua Cohen , David McLaughlin Cc: Aurora , Mehrdad Nurolahzade Date: Fri, 23 Dec 2016 08:10:59 -0000 Message-ID: <20161223081059.1709.26783@reviews.apache.org> X-ReviewBoard-URL: https://reviews.apache.org/ Auto-Submitted: auto-generated Sender: David McLaughlin X-ReviewGroup: Aurora X-Auto-Response-Suppress: DR, RN, OOF, AutoReply X-ReviewRequest-URL: https://reviews.apache.org/r/55003/ X-Sender: David McLaughlin X-ReviewBoard-ShipIt: 1 References: <20161223000633.1708.35418@reviews.apache.org> In-Reply-To: <20161223000633.1708.35418@reviews.apache.org> X-ReviewBoard-ShipIt-Only: 1 Reply-To: David McLaughlin X-ReviewRequest-Repository: aurora archived-at: Fri, 23 Dec 2016 08:11:02 -0000 --===============1645378972672328772== MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/55003/#review160043 ----------------------------------------------------------- Ship it! Ship It! - David McLaughlin On Dec. 23, 2016, 12:06 a.m., Mehrdad Nurolahzade wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/55003/ > ----------------------------------------------------------- > > (Updated Dec. 23, 2016, 12:06 a.m.) > > > Review request for Aurora, David McLaughlin and Joshua Cohen. > > > Bugs: AURORA-1848 > https://issues.apache.org/jira/browse/AURORA-1848 > > > Repository: aurora > > > Description > ------- > > AURORA-1848 Expose ResponseCode stats on Thrift server calls > > > Diffs > ----- > > src/main/java/org/apache/aurora/scheduler/thrift/aop/LoggingInterceptor.java fc89c81b898a711033b736678b72414bd85f0aa1 > src/test/java/org/apache/aurora/scheduler/thrift/aop/LoggingInterceptorTest.java 8dff558e5e8b4a181b207a8fb84385deb670189d > > Diff: https://reviews.apache.org/r/55003/diff/ > > > Testing > ------- > > ``` > curl 192.168.33.7:8081/vars | grep scheduler_thrift_response > % Total % Received % Xferd Average Speed Time Time Time Current > Dload Upload Total Spent Left Speed > 100 41837 0 41837 0 0 7013k 0 --:--:-- --:--:-- --:--:-- 8171k > scheduler_thrift_response_ERROR_TRANSIENT 1 > scheduler_thrift_response_OK 1 > ``` > > > Thanks, > > Mehrdad Nurolahzade > > --===============1645378972672328772==--