Mailing-List: contact reviews-help@aurora.apache.org; run by ezmlm
Precedence: bulk
Reply-To: reviews@aurora.apache.org
Content-Type: multipart/alternative;
 boundary="===============9174226523893098321=="
MIME-Version: 1.0
Subject: Re: Review Request 54774: Avoid double writing job updates to the
 Scheduler Snapshot
From: Joshua Cohen <jcohen@apache.org>
To: Santhosh Kumar Shanmugham <santhoshkumar.s@gmail.com>,
 Joshua Cohen <jcohen@apache.org>, Zameer Manji <zmanji@apache.org>
Cc: Aurora <reviews@aurora.apache.org>,
 David McLaughlin <david@dmclaughlin.com>
Date: Thu, 15 Dec 2016 19:21:56 -0000
Message-ID: <20161215192156.17251.42735@reviews.apache.org>
Auto-Submitted: auto-generated
Sender: Joshua Cohen <noreply@reviews.apache.org>
References: <20161215181618.17252.86893@reviews.apache.org>
In-Reply-To: <20161215181618.17252.86893@reviews.apache.org>
Reply-To: Joshua Cohen <jcohen@apache.org>
archived-at: Thu, 15 Dec 2016 19:21:59 -0000

--===============9174226523893098321==
MIME-Version: 1.0
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: 7bit


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/54774/#review159347
-----------------------------------------------------------


Fix it, then Ship it!


lgtm modulo the below.


src/main/java/org/apache/aurora/scheduler/storage/log/SnapshotStoreImpl.java (line 128)
<https://reviews.apache.org/r/54774/#comment230310>

    This `@Timed` annotation is on the wrong method now.


- Joshua Cohen


On Dec. 15, 2016, 6:16 p.m., David McLaughlin wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/54774/
> -----------------------------------------------------------
> 
> (Updated Dec. 15, 2016, 6:16 p.m.)
> 
> 
> Review request for Aurora, Joshua Cohen, Santhosh Kumar Shanmugham, and Zameer Manji.
> 
> 
> Bugs: AURORA-1861
>     https://issues.apache.org/jira/browse/AURORA-1861
> 
> 
> Repository: aurora
> 
> 
> Description
> -------
> 
> Motivation: Thanks to the mybatis query metrics we added, we found that double writing Snapshot fields for H2 stores adds considerable overhead to our snapshot creation time. 
> 
> Snapshots are also written as backups, and many operators choose to process backups offline for analytics, rather than query the live scheduler (due to not being able to scale reads horizontally). So this allows operators to enable/disable the hydrated fields as needed.
> 
> 
> Diffs
> -----
> 
>   src/main/java/org/apache/aurora/scheduler/storage/backup/TemporaryStorage.java 3fa408e283f91b313633959ea6d2e730d4dc0771 
>   src/main/java/org/apache/aurora/scheduler/storage/log/LogStorageModule.java 7dcd1bfcf303cf374e9a6627cb6c632ccea098f2 
>   src/main/java/org/apache/aurora/scheduler/storage/log/SnapshotStoreImpl.java 853780bc68400489578ed3692920aafcec42c999 
>   src/test/java/org/apache/aurora/scheduler/storage/backup/RecoveryTest.java 7a11850e217dcb0148e4a4d33542c95b2e53a726 
>   src/test/java/org/apache/aurora/scheduler/storage/log/SnapshotStoreImplIT.java cf0a8f3ea11e9c48d1f16441af54dc781b33bdfc 
> 
> Diff: https://reviews.apache.org/r/54774/diff/
> 
> 
> Testing
> -------
> 
> ./gradlew test
> 
> I'll apply this to one of our test clusters before merging to master too.
> 
> 
> Thanks,
> 
> David McLaughlin
> 
>


--===============9174226523893098321==--