Return-Path: X-Original-To: archive-asf-public-internal@cust-asf2.ponee.io Delivered-To: archive-asf-public-internal@cust-asf2.ponee.io Received: from cust-asf.ponee.io (cust-asf.ponee.io [163.172.22.183]) by cust-asf2.ponee.io (Postfix) with ESMTP id C51CC200BDD for ; Sat, 10 Dec 2016 21:14:45 +0100 (CET) Received: by cust-asf.ponee.io (Postfix) id C3BAE160B2B; Sat, 10 Dec 2016 20:14:45 +0000 (UTC) Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by cust-asf.ponee.io (Postfix) with SMTP id 19FC4160B1C for ; Sat, 10 Dec 2016 21:14:44 +0100 (CET) Received: (qmail 92957 invoked by uid 500); 10 Dec 2016 20:14:44 -0000 Mailing-List: contact reviews-help@aurora.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: reviews@aurora.apache.org Delivered-To: mailing list reviews@aurora.apache.org Received: (qmail 92924 invoked by uid 99); 10 Dec 2016 20:14:44 -0000 Received: from reviews-vm.apache.org (HELO reviews.apache.org) (140.211.11.40) by apache.org (qpsmtpd/0.29) with ESMTP; Sat, 10 Dec 2016 20:14:44 +0000 Received: from reviews.apache.org (localhost [127.0.0.1]) by reviews.apache.org (Postfix) with ESMTP id 4B08C2FA4F7; Sat, 10 Dec 2016 20:14:43 +0000 (UTC) Content-Type: multipart/alternative; boundary="===============1785726020656719991==" MIME-Version: 1.0 Subject: Re: Review Request 54624: Expose stats on ZooKeeper connection state From: Joshua Cohen To: Stephan Erb , Mehrdad Nurolahzade , Zameer Manji Cc: Joshua Cohen , Aurora , Jing Chen Date: Sat, 10 Dec 2016 20:14:43 -0000 Message-ID: <20161210201443.1680.5444@reviews.apache.org> X-ReviewBoard-URL: https://reviews.apache.org/ Auto-Submitted: auto-generated Sender: Joshua Cohen X-ReviewGroup: Aurora X-Auto-Response-Suppress: DR, RN, OOF, AutoReply X-ReviewRequest-URL: https://reviews.apache.org/r/54624/ X-Sender: Joshua Cohen References: <20161210110458.1678.69850@reviews.apache.org> In-Reply-To: <20161210110458.1678.69850@reviews.apache.org> Reply-To: Joshua Cohen X-ReviewRequest-Repository: aurora archived-at: Sat, 10 Dec 2016 20:14:46 -0000 --===============1785726020656719991== MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/54624/#review158773 ----------------------------------------------------------- I think the idea behind the ticket was to track these as stats, not just into the log. - Joshua Cohen On Dec. 10, 2016, 11:04 a.m., Jing Chen wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/54624/ > ----------------------------------------------------------- > > (Updated Dec. 10, 2016, 11:04 a.m.) > > > Review request for Aurora, Mehrdad Nurolahzade, Stephan Erb, and Zameer Manji. > > > Bugs: AURORA-1838 > https://issues.apache.org/jira/browse/AURORA-1838 > > > Repository: aurora > > > Description > ------- > > Expose stats on ZooKeeper connection state > > > Diffs > ----- > > src/main/java/org/apache/aurora/scheduler/discovery/CuratorServiceDiscoveryModule.java 999a542796858dcfe9e31601c47239189043fd52 > > Diff: https://reviews.apache.org/r/54624/diff/ > > > Testing > ------- > > State Change is logged into aurora-scheduler.log: > ``` > I1210 10:44:37.973 [main-EventThread, ConnectionStateManager] State change: CONNECTED > ``` > > > Thanks, > > Jing Chen > > --===============1785726020656719991==--