Return-Path: X-Original-To: archive-asf-public-internal@cust-asf2.ponee.io Delivered-To: archive-asf-public-internal@cust-asf2.ponee.io Received: from cust-asf.ponee.io (cust-asf.ponee.io [163.172.22.183]) by cust-asf2.ponee.io (Postfix) with ESMTP id 26DF8200BE8 for ; Fri, 9 Dec 2016 04:30:35 +0100 (CET) Received: by cust-asf.ponee.io (Postfix) id 2572E160B27; Fri, 9 Dec 2016 03:30:35 +0000 (UTC) Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by cust-asf.ponee.io (Postfix) with SMTP id 6FF06160B1F for ; Fri, 9 Dec 2016 04:30:34 +0100 (CET) Received: (qmail 34981 invoked by uid 500); 9 Dec 2016 03:30:33 -0000 Mailing-List: contact reviews-help@aurora.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: reviews@aurora.apache.org Delivered-To: mailing list reviews@aurora.apache.org Received: (qmail 34942 invoked by uid 99); 9 Dec 2016 03:30:33 -0000 Received: from reviews-vm.apache.org (HELO reviews.apache.org) (140.211.11.40) by apache.org (qpsmtpd/0.29) with ESMTP; Fri, 09 Dec 2016 03:30:33 +0000 Received: from reviews.apache.org (localhost [127.0.0.1]) by reviews.apache.org (Postfix) with ESMTP id D42782DACB9; Fri, 9 Dec 2016 03:30:32 +0000 (UTC) Content-Type: multipart/alternative; boundary="===============4008560909517368150==" MIME-Version: 1.0 Subject: Re: Review Request 54550: Specify python2.7 when extracting options from pants.ini during thrift bootstrap. From: John Sirois To: Santhosh Kumar Shanmugham Cc: Joshua Cohen , Aurora , John Sirois , Zameer Manji , Aurora ReviewBot Date: Fri, 09 Dec 2016 03:30:32 -0000 Message-ID: <20161209033032.1678.34314@reviews.apache.org> X-ReviewBoard-URL: https://reviews.apache.org/ Auto-Submitted: auto-generated Sender: John Sirois X-ReviewGroup: Aurora X-Auto-Response-Suppress: DR, RN, OOF, AutoReply X-ReviewRequest-URL: https://reviews.apache.org/r/54550/ X-Sender: John Sirois References: <20161209032944.15025.47007@reviews.apache.org> In-Reply-To: <20161209032944.15025.47007@reviews.apache.org> Reply-To: John Sirois X-ReviewRequest-Repository: aurora archived-at: Fri, 09 Dec 2016 03:30:35 -0000 --===============4008560909517368150== MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit > On Dec. 8, 2016, 8:29 p.m., John Sirois wrote: > > build-support/thrift/prepare_binary.sh, line 29 > > > > > > aha - popd on linux echos the dirstack - presumably it does not do this on osx... so needs a re-direct. Ditto pushd. And AuroraBot really does need to go green. ...where linux probably just means modern bash, osx - even Sierra IIUC, is wtfb (way tf behind). - John ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/54550/#review158632 ----------------------------------------------------------- On Dec. 8, 2016, 7:30 p.m., Joshua Cohen wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/54550/ > ----------------------------------------------------------- > > (Updated Dec. 8, 2016, 7:30 p.m.) > > > Review request for Aurora and Santhosh Kumar Shanmugham. > > > Repository: aurora > > > Description > ------- > > We have some CI machines internally where the default python doesn't have the `json` module, so this script fails. > > > Diffs > ----- > > build-support/thrift/prepare_binary.sh a96b33e4564604f72d8fcf284f0cf1adea1866a9 > > Diff: https://reviews.apache.org/r/54550/diff/ > > > Testing > ------- > > > Thanks, > > Joshua Cohen > > --===============4008560909517368150==--