Return-Path: X-Original-To: archive-asf-public-internal@cust-asf2.ponee.io Delivered-To: archive-asf-public-internal@cust-asf2.ponee.io Received: from cust-asf.ponee.io (cust-asf.ponee.io [163.172.22.183]) by cust-asf2.ponee.io (Postfix) with ESMTP id A672D200BE3 for ; Thu, 8 Dec 2016 03:40:18 +0100 (CET) Received: by cust-asf.ponee.io (Postfix) id A4F93160B26; Thu, 8 Dec 2016 02:40:18 +0000 (UTC) Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by cust-asf.ponee.io (Postfix) with SMTP id EDB16160B0C for ; Thu, 8 Dec 2016 03:40:17 +0100 (CET) Received: (qmail 8262 invoked by uid 500); 8 Dec 2016 02:40:17 -0000 Mailing-List: contact reviews-help@aurora.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: reviews@aurora.apache.org Delivered-To: mailing list reviews@aurora.apache.org Received: (qmail 8239 invoked by uid 99); 8 Dec 2016 02:40:16 -0000 Received: from reviews-vm.apache.org (HELO reviews.apache.org) (140.211.11.40) by apache.org (qpsmtpd/0.29) with ESMTP; Thu, 08 Dec 2016 02:40:16 +0000 Received: from reviews.apache.org (localhost [127.0.0.1]) by reviews.apache.org (Postfix) with ESMTP id 872C42DAB62; Thu, 8 Dec 2016 02:40:16 +0000 (UTC) Content-Type: multipart/alternative; boundary="===============2406440732455888365==" MIME-Version: 1.0 Subject: Re: Review Request 54299: Extend warm-up time by `max_consecutive_failures` attempts. From: Joshua Cohen To: Joshua Cohen , David McLaughlin , Zameer Manji Cc: Santhosh Kumar Shanmugham , Aurora Date: Thu, 08 Dec 2016 02:40:16 -0000 Message-ID: <20161208024016.15025.9255@reviews.apache.org> X-ReviewBoard-URL: https://reviews.apache.org/ Auto-Submitted: auto-generated Sender: Joshua Cohen X-ReviewGroup: Aurora X-Auto-Response-Suppress: DR, RN, OOF, AutoReply X-ReviewRequest-URL: https://reviews.apache.org/r/54299/ X-Sender: Joshua Cohen X-ReviewBoard-ShipIt: 1 References: <20161208001557.1678.2551@reviews.apache.org> In-Reply-To: <20161208001557.1678.2551@reviews.apache.org> X-ReviewBoard-ShipIt-Only: 1 Reply-To: Joshua Cohen X-ReviewRequest-Repository: aurora archived-at: Thu, 08 Dec 2016 02:40:18 -0000 --===============2406440732455888365== MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/54299/#review158490 ----------------------------------------------------------- Ship it! Ship It! - Joshua Cohen On Dec. 8, 2016, 12:15 a.m., Santhosh Kumar Shanmugham wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/54299/ > ----------------------------------------------------------- > > (Updated Dec. 8, 2016, 12:15 a.m.) > > > Review request for Aurora, David McLaughlin, Joshua Cohen, and Zameer Manji. > > > Bugs: AURORA-1841 > https://issues.apache.org/jira/browse/AURORA-1841 > > > Repository: aurora > > > Description > ------- > > It is possible to set the health checks such that a task can > continually fail health checks with intermittent successes and still > succeed an update. Essentially a task fails health checks during the > `initial_interval_secs` and an additional `max_consecutive_failures`, > and then perform a successful health check to become healthy. > > To be backward compatible to the above configuration, include the > `max_consecutive_failures` when computing `max_attempts_to_running`. > > > Diffs > ----- > > docs/features/services.md 50189eeff26ce9614d092f6abd9246788647fe2b > src/main/python/apache/aurora/executor/aurora_executor.py d01fcb9594552eb6cdfbdbab2d03707738df3443 > src/main/python/apache/aurora/executor/common/health_checker.py 12af9d8635a553eabe918a86508aa6ce2fd78a49 > src/test/python/apache/aurora/executor/common/test_health_checker.py e2a7f164a24f49dd1f4cdba136e838b9d42d73a2 > > Diff: https://reviews.apache.org/r/54299/diff/ > > > Testing > ------- > > build-support/jenkins/build.sh > src/test/sh/org/apacher/aurora/e2e/test_end_to_end.sh > > > Thanks, > > Santhosh Kumar Shanmugham > > --===============2406440732455888365==--