Return-Path: X-Original-To: archive-asf-public-internal@cust-asf2.ponee.io Delivered-To: archive-asf-public-internal@cust-asf2.ponee.io Received: from cust-asf.ponee.io (cust-asf.ponee.io [163.172.22.183]) by cust-asf2.ponee.io (Postfix) with ESMTP id CB7EB200BD4 for ; Thu, 1 Dec 2016 18:22:57 +0100 (CET) Received: by cust-asf.ponee.io (Postfix) id CA252160B0B; Thu, 1 Dec 2016 17:22:57 +0000 (UTC) Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by cust-asf.ponee.io (Postfix) with SMTP id 1E2A5160B05 for ; Thu, 1 Dec 2016 18:22:56 +0100 (CET) Received: (qmail 16847 invoked by uid 500); 1 Dec 2016 17:22:56 -0000 Mailing-List: contact reviews-help@aurora.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: reviews@aurora.apache.org Delivered-To: mailing list reviews@aurora.apache.org Received: (qmail 16827 invoked by uid 99); 1 Dec 2016 17:22:56 -0000 Received: from reviews-vm.apache.org (HELO reviews.apache.org) (140.211.11.40) by apache.org (qpsmtpd/0.29) with ESMTP; Thu, 01 Dec 2016 17:22:56 +0000 Received: from reviews.apache.org (localhost [127.0.0.1]) by reviews.apache.org (Postfix) with ESMTP id 729452D7C5E; Thu, 1 Dec 2016 17:22:53 +0000 (UTC) Content-Type: multipart/alternative; boundary="===============9148205788354908971==" MIME-Version: 1.0 Subject: Re: Review Request 54255: WIP: Update to Mesos 1.1.0. From: Stephan Erb To: Joshua Cohen , Aurora , Aurora ReviewBot Date: Thu, 01 Dec 2016 17:22:53 -0000 Message-ID: <20161201172253.1641.39259@reviews.apache.org> X-ReviewBoard-URL: https://reviews.apache.org/ Auto-Submitted: auto-generated Sender: Stephan Erb X-ReviewGroup: Aurora X-Auto-Response-Suppress: DR, RN, OOF, AutoReply X-ReviewRequest-URL: https://reviews.apache.org/r/54255/ X-Sender: Stephan Erb References: <20161201172009.1641.46939@reviews.apache.org> In-Reply-To: <20161201172009.1641.46939@reviews.apache.org> Reply-To: Stephan Erb X-ReviewRequest-Repository: aurora archived-at: Thu, 01 Dec 2016 17:22:58 -0000 --===============9148205788354908971== MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit > On Dez. 1, 2016, 6:20 nachm., Joshua Cohen wrote: > > src/main/java/org/apache/aurora/scheduler/configuration/executor/ExecutorSettingsLoader.java, line 95 > > > > > > What's the reasoning for this change? I got a nullptr exception. I suppose Mesos has changed an argument to become optional but I didn't have time to investigate, yet. - Stephan ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/54255/#review157610 ----------------------------------------------------------- On Dez. 1, 2016, 5:34 nachm., Stephan Erb wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/54255/ > ----------------------------------------------------------- > > (Updated Dez. 1, 2016, 5:34 nachm.) > > > Review request for Aurora. > > > Bugs: AURORA-1813 > https://issues.apache.org/jira/browse/AURORA-1813 > > > Repository: aurora > > > Description > ------- > > I will finish this work early next week. I will let you know when this patch is ready for review/merge. > > What have I done already: > > * uploaded the new egg files. > > What is still missing: > > * rebuild our packer image > * update vagrant box to use the new image > * prepare aurora-packaging for Mesos 1.1.0 > * run end-to-end tests > > > Diffs > ----- > > 3rdparty/python/BUILD c572da02e68957567eca0fc3cde9c518aa4fe126 > build-support/packer/build.sh 2fb4723ed4d57be25371c6b60375044c857afabd > build-support/python/make-mesos-native-egg bcc6e85abb7536002afb3071c08e2008bcc1ecca > build.gradle f257440e67384d9bd223b3c39785525bdb54dd9b > src/main/java/org/apache/aurora/scheduler/base/Conversions.java 4a1e0876609ce8eda457c0174e3ea3fbb8609376 > src/main/java/org/apache/aurora/scheduler/configuration/executor/ExecutorSettingsLoader.java 7dc9eff2c7058e90eb93f7d7f4f378e8883989e5 > > Diff: https://reviews.apache.org/r/54255/diff/ > > > Testing > ------- > > ./gradlew -Pq build > ./pants test.pytest src/{main,test}/python:: -- -v > > > Thanks, > > Stephan Erb > > --===============9148205788354908971==--