aurora-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From David McLaughlin <da...@dmclaughlin.com>
Subject Re: Review Request 55003: AURORA-1848 Expose ResponseCode stats on Thrift server calls
Date Fri, 23 Dec 2016 08:10:59 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/55003/#review160043
-----------------------------------------------------------


Ship it!




Ship It!

- David McLaughlin


On Dec. 23, 2016, 12:06 a.m., Mehrdad Nurolahzade wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/55003/
> -----------------------------------------------------------
> 
> (Updated Dec. 23, 2016, 12:06 a.m.)
> 
> 
> Review request for Aurora, David McLaughlin and Joshua Cohen.
> 
> 
> Bugs: AURORA-1848
>     https://issues.apache.org/jira/browse/AURORA-1848
> 
> 
> Repository: aurora
> 
> 
> Description
> -------
> 
> AURORA-1848 Expose ResponseCode stats on Thrift server calls
> 
> 
> Diffs
> -----
> 
>   src/main/java/org/apache/aurora/scheduler/thrift/aop/LoggingInterceptor.java fc89c81b898a711033b736678b72414bd85f0aa1

>   src/test/java/org/apache/aurora/scheduler/thrift/aop/LoggingInterceptorTest.java 8dff558e5e8b4a181b207a8fb84385deb670189d

> 
> Diff: https://reviews.apache.org/r/55003/diff/
> 
> 
> Testing
> -------
> 
> ```
> curl 192.168.33.7:8081/vars | grep scheduler_thrift_response
>   % Total    % Received % Xferd  Average Speed   Time    Time     Time  Current
>                                  Dload  Upload   Total   Spent    Left  Speed
> 100 41837    0 41837    0     0  7013k      0 --:--:-- --:--:-- --:--:-- 8171k
> scheduler_thrift_response_ERROR_TRANSIENT 1
> scheduler_thrift_response_OK 1
> ```
> 
> 
> Thanks,
> 
> Mehrdad Nurolahzade
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message