aurora-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Mehrdad Nurolahzade <mehr...@nurolahzade.com>
Subject Re: Review Request 54960: Exposed stats on number of offers rescinded and number of slaves lost.
Date Thu, 22 Dec 2016 01:23:42 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/54960/#review159902
-----------------------------------------------------------



Could you please refactor away from `Stats`, as was suggested by @zmanji on a similar rb [https://reviews.apache.org/r/54959/]?

- Mehrdad Nurolahzade


On Dec. 21, 2016, 4:58 p.m., Pradyumna Kaushik wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/54960/
> -----------------------------------------------------------
> 
> (Updated Dec. 21, 2016, 4:58 p.m.)
> 
> 
> Review request for Aurora and Mehrdad Nurolahzade.
> 
> 
> Repository: aurora
> 
> 
> Description
> -------
> 
> Exposed stats on number of offers rescinded and number of slaves lost.
> 
> 
> Diffs
> -----
> 
>   src/main/java/org/apache/aurora/scheduler/mesos/MesosSchedulerImpl.java d63bfc10442b791b423d0d8c83cc280610103299

> 
> Diff: https://reviews.apache.org/r/54960/diff/
> 
> 
> Testing
> -------
> 
> ./build-support/jenkins/build.sh
> ./src/test/sh/org/apache/aurora/e2e/test_end_to_end.sh
> 
> 
> Thanks,
> 
> Pradyumna Kaushik
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message